Use gitignore when finding project files

[jfaz1]

This PR takes into account .gitignore when finding project files in git repos by default. Toggle with *respect-gitignore*.

Besides having more accurate autocomplete (e.g. ignoring .git/node_modules), project-find-file is actually usable on large projects now (e.g. autocomplete Linux kernel would take ~5 seconds to show up, now shows up instantly).

[vindarel]

wait! Now this command will list all files including all node_modules/ that are normally ignored.

How are they ignored? Automatically by a call to the fdfind program. Which also respects .gitignore, .ignore (and .fdignore) by default. You didn't know about that, surely?

For a full Lisp solution, very welcome, we should ignore node_modules too :S What other big repositories should we ignore?

[vindarel]

this command should be tweakable -> global parameter.

[jfaz1]

wait! Now this command will list all files including all node_modules/ that are normally ignored.

What do you mean? Won't they be ignored by git ls-files since they're in the .gitignore?

How are they ignored? Automatically by a call to the fdfind program. Which also respects .gitignore, .ignore (and .fdignore) by default. You didn't know about that, surely?

Hahh I had no idea it tried using fdfind, just found the snippet that tries. That's actually a better solution since it's more robust and not git-specific. I just didn't want to introduce another dependency but I like it a lot more. Maybe we should just throw a line in the docs mentioning it.
Edit: Nvm, found the line mentioning it. My bad 😆

Thanks! 😄

[vindarel]

I'm sorry, I'm adding a section in the Install doc to mention it earlier.

But wait! again, because if fd isn't present the project command relies on a Lisp function that doesn't have the same behavior of ignoring files (with a slight "IIRC" prudency touch, details to be double-checked). So your code would be useful for the fallback case.

[jfaz1]

I'm sorry, I'm adding a section in the Install doc to mention it earlier.

You're good, I'm the one that missed it 😆

But wait! again, because if fd isn't present the project command relies on a Lisp function that doesn't have the same behavior of ignoring files (with a slight "IIRC" prudency touch, details to be double-checked). So your code would be useful for the fallback case.

Yeah, if fd isn't present it uses the function that doesn't ignore them which is why I made the PR. I'm on a clean install which is why I noticed the .gitignored files showing up, I had fd in my previous setup, just didn't realize that was why. I think maybe instead of using this as a fallback, we could add fd/fd-find packages to the install instructions? It makes for a better experience in general anyways.