Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Add unix socket support? #172

Draft
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

javaarchive
Copy link

image
Works on my machine borrowing most of the code from the tcp adapter. Has some implementation issues that I'll be putting as a list here:

  • peer and remote address is set to a filler value because there is a different SocketAddr type than required, not sure how I can convert between the two.
  • As seen in Trait implementation of adapters that cannot accept a socket address? #171 , the path of the unix socket is currently hacked in via other options and the SocketAddr is completley ignored, considering using an Option here.
  • Throughput has no native UnixSocket test yet.

@javaarchive javaarchive marked this pull request as draft May 31, 2024 06:33
remote: Self {
stream
},
// the unixstream uses SocketAddr from mio that can't be converted
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, what then identifies an unix socket?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

local_addr and peer_addr are currently a placeholder value, the unix sockets seem to have a totally different local and peer addr format.

@javaarchive
Copy link
Author

Tested in release, websocket is only slow in debug for some reason, here is an output from the same computer for reference:

Sending 1GB in chunks of 65507 bytes:

message-io Udp:  	Throughput: 9.24 GB/s
message-io Tcp:  	Throughput: 5.68 GB/s
message-io FramedTcp:  	Throughput: 4.49 GB/s
message-io Ws:  	Throughput: 1.85 GB/s
message-io UnixSocket:  	Throughput: 9.61 GB/s

native Udp: 		Throughput: 10.24 GB/s
native Tcp: 		Throughput: 6.08 GB/s
native FramedTcp: 	Throughput: 4.78 GB/s
native Ws: 		Throughput: 1.94 GB/s

@javaarchive
Copy link
Author

javaarchive commented Jun 2, 2024

Discovered implementation issue where messages sent after each other without a sleep are dropped.

Edit: this is fine for the stream based protocol

@javaarchive
Copy link
Author

image
Datagram support throughput (in debug).
For release:
image
I'm still finding it odd that the stream based transport slows down in release but that might just be variation while I'm testing this.

@javaarchive
Copy link
Author

Due to unix datagram sockets not really having an IPv4 or IPv6 that fits in the SocketAddr struct, the implementation is partially broken for now.
I may see if I can change the types on a separate branch as an experiment.

@lemunozm
Copy link
Owner

lemunozm commented Jun 4, 2024

Hi @javaarchive, Mmmm... interesting the throughput issue. At such speeds could be noise in the runs. Is it always faster in debug or sometimes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants