-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add unix socket support? #172
base: master
Are you sure you want to change the base?
Conversation
remote: Self { | ||
stream | ||
}, | ||
// the unixstream uses SocketAddr from mio that can't be converted |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, what then identifies an unix socket?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
local_addr and peer_addr are currently a placeholder value, the unix sockets seem to have a totally different local and peer addr format.
Tested in release, websocket is only slow in debug for some reason, here is an output from the same computer for reference:
|
Discovered implementation issue where messages sent after each other without a sleep are dropped. Edit: this is fine for the stream based protocol |
Due to unix datagram sockets not really having an IPv4 or IPv6 that fits in the SocketAddr struct, the implementation is partially broken for now. |
Hi @javaarchive, Mmmm... interesting the throughput issue. At such speeds could be noise in the runs. Is it always faster in |
Works on my machine borrowing most of the code from the tcp adapter. Has some implementation issues that I'll be putting as a list here: