Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrating s3 put to tm upload #28

Merged
merged 3 commits into from
Dec 5, 2018
Merged

migrating s3 put to tm upload #28

merged 3 commits into from
Dec 5, 2018

Conversation

loran-steinberger
Copy link
Contributor

@loran-steinberger loran-steinberger commented Dec 4, 2018

TODO: bump the version.

Relevant:

Q: How much data can I store in Amazon S3?

The total volume of data and number of objects you can store are unlimited. Individual Amazon S3 objects can range in size from a minimum of 0 bytes to a maximum of 5 terabytes. The largest object that can be uploaded in a single PUT is 5 gigabytes. For objects larger than 100 megabytes, customers should consider using the Multipart Upload capability.

AWS guidance is use TransferManager/Mulitpart upload for anything over 100mb

Copy link

@srki-lendup srki-lendup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. We already have tests covering the upload/ putObject?

@matthewgraf
Copy link

I believe we have tests covering this. There are some integration tests that are disabled but can be run locally (some of them are designed to actually interact with s3, Box, or whatever store you are working with)
Also I'm not sure what is standard practice with versioning, but I would think we probably want to bump the version number for any change

@srki-lendup
Copy link

Agree with Matt on version bump.

@stew
Copy link
Contributor

stew commented Dec 4, 2018

if you are changing a public signature it should be a version bump

@rolandomanrique
Copy link
Contributor

I believe we have tests covering this. There are some integration tests that are disabled but can be run locally (some of them are designed to actually interact with s3, Box, or whatever store you are working with)

@matthewgraf I set up tests to run against Minio (dockerized S3) so S3 tests are running in travis (I filed issue #25 to fix codecov publishing).

Agree we should bump version.

Otherwise this looks good to me.

@matthewgraf
Copy link

matthewgraf commented Dec 5, 2018

Agree we should bump version.

@rolandomanrique where is the version changed? I was looking over this with @lumengxi and it looks like the version in version.sbt is out of sync with the latest on Sonatype as well as the latest in the repo "Releases" tab

@loran-steinberger
Copy link
Contributor Author

loran-steinberger commented Dec 5, 2018

Reconciling all version references to the same- 0.3.0

@loran-steinberger
Copy link
Contributor Author

#release @rolandomanrique

@loran-steinberger loran-steinberger merged commit a2ab6bb into master Dec 5, 2018
@loran-steinberger loran-steinberger deleted the s3-tm branch December 5, 2018 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants