code review, pass config instead of logger

lens-protocol · Jan 15, 2024 · 7d72f8c · 7d72f8c
1 parent 087438d
commit 7d72f8c
Show file tree

Hide file tree

Showing 44 changed files with 156 additions and 128 deletions.
diff --git a/packages/react/src/transactions/adapters/AbstractContractCallGateway.ts b/packages/react/src/transactions/adapters/AbstractContractCallGateway.ts
@@ -5,16 +5,10 @@ import {
   AnyTransactionRequest,
   IPaidTransactionGateway,
 } from '@lens-protocol/domain/use-cases/transactions';
-import {
-  Amount,
-  ChainType,
-  Data,
-  EvmAddress,
-  ILogger,
-  LoggerLevel,
-} from '@lens-protocol/shared-kernel';
+import { Amount, ChainType, Data, EvmAddress } from '@lens-protocol/shared-kernel';
 import { v4 } from 'uuid';
 
+import { LensConfig } from '../../config';
 import { ITransactionRequest } from '../../wallet/adapters/ConcreteWallet';
 import { IProviderFactory } from '../../wallet/adapters/IProviderFactory';
 import { Eip1559GasPriceEstimator, TransactionExecutionSpeed } from './Eip1559GasPriceEstimator';
@@ -36,7 +30,7 @@ export type ContractCallDetails = {
 export abstract class AbstractContractCallGateway<TRequest extends AnyTransactionRequest>
   implements IPaidTransactionGateway<TRequest>
 {
-  constructor(readonly logger: ILogger, private readonly providerFactory: IProviderFactory) {}
+  constructor(readonly config: LensConfig, private readonly providerFactory: IProviderFactory) {}
 
   async createUnsignedTransaction(
     request: TRequest,
@@ -48,12 +42,13 @@ export abstract class AbstractContractCallGateway<TRequest extends AnyTransactio
 
     const { contractAddress, encodedData } = await this.createEncodedData(request);
 
-    // skip gas estimation if debug mode is enabled
-    if (this.logger.level === LoggerLevel.Debug) {
+    // skip gas limit if debug mode is enabled
+    if (this.config.debug) {
       const transactionRequest = {
         to: contractAddress,
         from: wallet.address,
         data: encodedData,
+        type: 2, // EIP-1559
       };
 
       return new UnsignedContractCallTransaction(request, transactionRequest);

diff --git a/packages/react/src/transactions/adapters/OpenActionGateway.ts b/packages/react/src/transactions/adapters/OpenActionGateway.ts
@@ -29,9 +29,10 @@ import {
   IPaidTransactionGateway,
   ISignedOnChainGateway,
 } from '@lens-protocol/domain/use-cases/transactions';
-import { ChainType, Data, ILogger, PromiseResult, success } from '@lens-protocol/shared-kernel';
+import { ChainType, Data, PromiseResult, success } from '@lens-protocol/shared-kernel';
 import { v4 } from 'uuid';
 
+import { LensConfig } from '../../config';
 import { UnsignedProtocolCall } from '../../wallet/adapters/ConcreteWallet';
 import { IProviderFactory } from '../../wallet/adapters/IProviderFactory';
 import { AbstractContractCallGateway, ContractCallDetails } from './AbstractContractCallGateway';
@@ -51,12 +52,12 @@ export class OpenActionGateway
     IPaidTransactionGateway<OpenActionRequest>
 {
   constructor(
-    logger: ILogger,
+    config: LensConfig,
     private readonly apolloClient: SafeApolloClient,
     private readonly transactionFactory: ITransactionFactory<OpenActionRequest>,
     providerFactory: IProviderFactory,
   ) {
-    super(logger, providerFactory);
+    super(config, providerFactory);
   }
 
   async createDelegatedTransaction(

diff --git a/packages/react/src/transactions/adapters/__tests__/ApproveTransactionGateway.spec.ts b/packages/react/src/transactions/adapters/__tests__/ApproveTransactionGateway.spec.ts
@@ -7,10 +7,10 @@ import {
   TokenAllowanceLimit,
   TokenAllowanceRequest,
 } from '@lens-protocol/domain/use-cases/transactions';
-import { ILogger } from '@lens-protocol/shared-kernel';
 import { BigNumber, constants, providers, utils } from 'ethers';
 import { mock } from 'jest-mock-extended';
 
+import { LensConfig } from '../../../config';
 import { mockIProviderFactory } from '../../../wallet/adapters/__helpers__/mocks';
 import { UnsignedContractCallTransaction } from '../AbstractContractCallGateway';
 import { ApproveTransactionGateway } from '../ApproveTransactionGateway';
@@ -23,13 +23,13 @@ function setupApproveTransactionGateway({
   request: TokenAllowanceRequest;
   provider: providers.JsonRpcProvider;
 }) {
-  const logger = mock<ILogger>();
+  const config = mock<LensConfig>();
   const providerFactory = mockIProviderFactory({
     chainType: request.amount.asset.chainType,
     provider,
   });
 
-  return new ApproveTransactionGateway(logger, providerFactory);
+  return new ApproveTransactionGateway(config, providerFactory);
 }
 
 describe(`Given an instance of the ${ApproveTransactionGateway.name}`, () => {

diff --git a/packages/react/src/transactions/adapters/__tests__/OpenActionGateway.spec.ts b/packages/react/src/transactions/adapters/__tests__/OpenActionGateway.spec.ts
@@ -31,11 +31,12 @@ import {
   BroadcastingError,
   BroadcastingErrorReason,
 } from '@lens-protocol/domain/use-cases/transactions';
-import { ChainType, Data, ILogger } from '@lens-protocol/shared-kernel';
+import { ChainType, Data } from '@lens-protocol/shared-kernel';
 import { mockEvmAddress } from '@lens-protocol/shared-kernel/mocks';
 import { providers } from 'ethers';
 import { mock } from 'jest-mock-extended';
 
+import { LensConfig } from '../../../config';
 import { UnsignedProtocolCall } from '../../../wallet/adapters/ConcreteWallet';
 import { mockIProviderFactory } from '../../../wallet/adapters/__helpers__/mocks';
 import { UnsignedContractCallTransaction } from '../AbstractContractCallGateway';
@@ -53,15 +54,15 @@ function setupTestScenario({
   apolloClient: SafeApolloClient;
   provider?: providers.JsonRpcProvider;
 }) {
-  const logger = mock<ILogger>();
+  const config = mock<LensConfig>();
   const transactionFactory = mockITransactionFactory();
 
   const providerFactory = mockIProviderFactory({
     chainType: ChainType.POLYGON,
     provider,
   });
 
-  const gateway = new OpenActionGateway(logger, apolloClient, transactionFactory, providerFactory);
+  const gateway = new OpenActionGateway(config, apolloClient, transactionFactory, providerFactory);
 
   return { gateway };
 }

diff --git a/packages/react/src/transactions/adapters/profiles/BlockProfilesGateway.ts b/packages/react/src/transactions/adapters/profiles/BlockProfilesGateway.ts
@@ -18,9 +18,10 @@ import {
   IDelegatedTransactionGateway,
   ISignedOnChainGateway,
 } from '@lens-protocol/domain/use-cases/transactions';
-import { ChainType, Data, ILogger, PromiseResult, success } from '@lens-protocol/shared-kernel';
+import { ChainType, Data, PromiseResult, success } from '@lens-protocol/shared-kernel';
 import { v4 } from 'uuid';
 
+import { LensConfig } from '../../../config';
 import { UnsignedProtocolCall } from '../../../wallet/adapters/ConcreteWallet';
 import { IProviderFactory } from '../../../wallet/adapters/IProviderFactory';
 import { AbstractContractCallGateway, ContractCallDetails } from '../AbstractContractCallGateway';
@@ -34,12 +35,12 @@ export class BlockProfilesGateway
     ISignedOnChainGateway<BlockProfilesRequest>
 {
   constructor(
-    logger: ILogger,
+    config: LensConfig,
     providerFactory: IProviderFactory,
     private readonly apolloClient: SafeApolloClient,
     private readonly transactionFactory: ITransactionFactory<BlockProfilesRequest>,
   ) {
-    super(logger, providerFactory);
+    super(config, providerFactory);
   }
 
   async createDelegatedTransaction(

diff --git a/packages/react/src/transactions/adapters/profiles/FollowProfileGateway.ts b/packages/react/src/transactions/adapters/profiles/FollowProfileGateway.ts
@@ -26,9 +26,10 @@ import {
   IPaidTransactionGateway,
   ISignedOnChainGateway,
 } from '@lens-protocol/domain/use-cases/transactions';
-import { ChainType, Data, ILogger, PromiseResult, success } from '@lens-protocol/shared-kernel';
+import { ChainType, Data, PromiseResult, success } from '@lens-protocol/shared-kernel';
 import { v4 } from 'uuid';
 
+import { LensConfig } from '../../../config';
 import { UnsignedProtocolCall } from '../../../wallet/adapters/ConcreteWallet';
 import { IProviderFactory } from '../../../wallet/adapters/IProviderFactory';
 import { AbstractContractCallGateway, ContractCallDetails } from '../AbstractContractCallGateway';
@@ -63,12 +64,12 @@ export class FollowProfileGateway
     IPaidTransactionGateway<FollowRequest>
 {
   constructor(
-    logger: ILogger,
+    config: LensConfig,
     providerFactory: IProviderFactory,
     private readonly apolloClient: SafeApolloClient,
     private readonly transactionFactory: ITransactionFactory<FreeFollowRequest>,
   ) {
-    super(logger, providerFactory);
+    super(config, providerFactory);
   }
 
   async createDelegatedTransaction(

diff --git a/packages/react/src/transactions/adapters/profiles/LinkHandleGateway.ts b/packages/react/src/transactions/adapters/profiles/LinkHandleGateway.ts
@@ -18,9 +18,10 @@ import {
   IDelegatedTransactionGateway,
   ISignedOnChainGateway,
 } from '@lens-protocol/domain/use-cases/transactions';
-import { ChainType, Data, ILogger, PromiseResult, success } from '@lens-protocol/shared-kernel';
+import { ChainType, Data, PromiseResult, success } from '@lens-protocol/shared-kernel';
 import { v4 } from 'uuid';
 
+import { LensConfig } from '../../../config';
 import { UnsignedProtocolCall } from '../../../wallet/adapters/ConcreteWallet';
 import { IProviderFactory } from '../../../wallet/adapters/IProviderFactory';
 import { AbstractContractCallGateway, ContractCallDetails } from '../AbstractContractCallGateway';
@@ -34,12 +35,12 @@ export class LinkHandleGateway
     ISignedOnChainGateway<LinkHandleRequest>
 {
   constructor(
-    logger: ILogger,
+    config: LensConfig,
     providerFactory: IProviderFactory,
     private readonly apolloClient: SafeApolloClient,
     private readonly transactionFactory: ITransactionFactory<LinkHandleRequest>,
   ) {
-    super(logger, providerFactory);
+    super(config, providerFactory);
   }
 
   async createDelegatedTransaction(

diff --git a/packages/react/src/transactions/adapters/profiles/ProfileMetadataGateway.ts b/packages/react/src/transactions/adapters/profiles/ProfileMetadataGateway.ts
@@ -19,9 +19,10 @@ import {
   IPaidTransactionGateway,
   ISignedOnChainGateway,
 } from '@lens-protocol/domain/use-cases/transactions';
-import { ChainType, Data, ILogger, PromiseResult, success } from '@lens-protocol/shared-kernel';
+import { ChainType, Data, PromiseResult, success } from '@lens-protocol/shared-kernel';
 import { v4 } from 'uuid';
 
+import { LensConfig } from '../../../config';
 import { UnsignedProtocolCall } from '../../../wallet/adapters/ConcreteWallet';
 import { IProviderFactory } from '../../../wallet/adapters/IProviderFactory';
 import { AbstractContractCallGateway, ContractCallDetails } from '../AbstractContractCallGateway';
@@ -36,12 +37,12 @@ export class ProfileMetadataGateway
     IPaidTransactionGateway<SetProfileMetadataRequest>
 {
   constructor(
-    logger: ILogger,
+    config: LensConfig,
     providerFactory: IProviderFactory,
     private readonly apolloClient: SafeApolloClient,
     private readonly transactionFactory: ITransactionFactory<SetProfileMetadataRequest>,
   ) {
-    super(logger, providerFactory);
+    super(config, providerFactory);
   }
 
   async createDelegatedTransaction(

diff --git a/packages/react/src/transactions/adapters/profiles/UnblockProfilesGateway.ts b/packages/react/src/transactions/adapters/profiles/UnblockProfilesGateway.ts
@@ -18,16 +18,10 @@ import {
   IDelegatedTransactionGateway,
   ISignedOnChainGateway,
 } from '@lens-protocol/domain/use-cases/transactions';
-import {
-  ChainType,
-  Data,
-  ILogger,
-  PromiseResult,
-  failure,
-  success,
-} from '@lens-protocol/shared-kernel';
+import { ChainType, Data, PromiseResult, failure, success } from '@lens-protocol/shared-kernel';
 import { v4 } from 'uuid';
 
+import { LensConfig } from '../../../config';
 import { UnsignedProtocolCall } from '../../../wallet/adapters/ConcreteWallet';
 import { IProviderFactory } from '../../../wallet/adapters/IProviderFactory';
 import { AbstractContractCallGateway, ContractCallDetails } from '../AbstractContractCallGateway';
@@ -41,12 +35,12 @@ export class UnblockProfilesGateway
     ISignedOnChainGateway<UnblockProfilesRequest>
 {
   constructor(
-    logger: ILogger,
+    config: LensConfig,
     providerFactory: IProviderFactory,
     private readonly apolloClient: SafeApolloClient,
     private readonly transactionFactory: ITransactionFactory<UnblockProfilesRequest>,
   ) {
-    super(logger, providerFactory);
+    super(config, providerFactory);
   }
 
   async createDelegatedTransaction(

diff --git a/packages/react/src/transactions/adapters/profiles/UnfollowProfileGateway.ts b/packages/react/src/transactions/adapters/profiles/UnfollowProfileGateway.ts
@@ -21,6 +21,7 @@ import {
 import { ChainType, Data, PromiseResult, success } from '@lens-protocol/shared-kernel';
 import { v4 } from 'uuid';
 
+import { LensConfig } from '../../../config';
 import { UnsignedProtocolCall } from '../../../wallet/adapters/ConcreteWallet';
 import { IProviderFactory } from '../../../wallet/adapters/IProviderFactory';
 import { AbstractContractCallGateway, ContractCallDetails } from '../AbstractContractCallGateway';
@@ -32,11 +33,12 @@ export class UnfollowProfileGateway
   implements IDelegatedTransactionGateway<UnfollowRequest>, ISignedOnChainGateway<UnfollowRequest>
 {
   constructor(
+    config: LensConfig,
     providerFactory: IProviderFactory,
     private readonly apolloClient: SafeApolloClient,
     private readonly transactionFactory: ITransactionFactory<UnfollowRequest>,
   ) {
-    super(providerFactory);
+    super(config, providerFactory);
   }
 
   async createDelegatedTransaction(

diff --git a/packages/react/src/transactions/adapters/profiles/UnlinkHandleGateway.ts b/packages/react/src/transactions/adapters/profiles/UnlinkHandleGateway.ts
@@ -18,9 +18,10 @@ import {
   IDelegatedTransactionGateway,
   ISignedOnChainGateway,
 } from '@lens-protocol/domain/use-cases/transactions';
-import { ChainType, Data, ILogger, PromiseResult, success } from '@lens-protocol/shared-kernel';
+import { ChainType, Data, PromiseResult, success } from '@lens-protocol/shared-kernel';
 import { v4 } from 'uuid';
 
+import { LensConfig } from '../../../config';
 import { UnsignedProtocolCall } from '../../../wallet/adapters/ConcreteWallet';
 import { IProviderFactory } from '../../../wallet/adapters/IProviderFactory';
 import { AbstractContractCallGateway, ContractCallDetails } from '../AbstractContractCallGateway';
@@ -34,12 +35,12 @@ export class UnlinkHandleGateway
     ISignedOnChainGateway<UnlinkHandleRequest>
 {
   constructor(
-    logger: ILogger,
+    config: LensConfig,
     providerFactory: IProviderFactory,
     private readonly apolloClient: SafeApolloClient,
     private readonly transactionFactory: ITransactionFactory<UnlinkHandleRequest>,
   ) {
-    super(logger, providerFactory);
+    super(config, providerFactory);
   }
 
   async createDelegatedTransaction(

diff --git a/packages/react/src/transactions/adapters/profiles/UpdateFollowPolicyGateway.ts b/packages/react/src/transactions/adapters/profiles/UpdateFollowPolicyGateway.ts
@@ -24,9 +24,10 @@ import {
   IPaidTransactionGateway,
   ISignedOnChainGateway,
 } from '@lens-protocol/domain/use-cases/transactions';
-import { ChainType, Data, ILogger, PromiseResult, success } from '@lens-protocol/shared-kernel';
+import { ChainType, Data, PromiseResult, success } from '@lens-protocol/shared-kernel';
 import { v4 } from 'uuid';
 
+import { LensConfig } from '../../../config';
 import { UnsignedProtocolCall } from '../../../wallet/adapters/ConcreteWallet';
 import { IProviderFactory } from '../../../wallet/adapters/IProviderFactory';
 import { AbstractContractCallGateway, ContractCallDetails } from '../AbstractContractCallGateway';
@@ -64,12 +65,12 @@ export class UpdateFollowPolicyGateway
     IPaidTransactionGateway<UpdateFollowPolicyRequest>
 {
   constructor(
-    logger: ILogger,
+    config: LensConfig,
     providerFactory: IProviderFactory,
     private readonly apolloClient: SafeApolloClient,
     private readonly transactionFactory: ITransactionFactory<UpdateFollowPolicyRequest>,
   ) {
-    super(logger, providerFactory);
+    super(config, providerFactory);
   }
 
   async createDelegatedTransaction(

diff --git a/packages/react/src/transactions/adapters/profiles/UpdateProfileManagersGateway.ts b/packages/react/src/transactions/adapters/profiles/UpdateProfileManagersGateway.ts
@@ -11,8 +11,9 @@ import { lensHub } from '@lens-protocol/blockchain-bindings';
 import { Nonce } from '@lens-protocol/domain/entities';
 import { UpdateProfileManagersRequest } from '@lens-protocol/domain/use-cases/profile';
 import { ISignedOnChainGateway } from '@lens-protocol/domain/use-cases/transactions';
-import { Data, ILogger } from '@lens-protocol/shared-kernel';
+import { Data } from '@lens-protocol/shared-kernel';
 
+import { LensConfig } from '../../../config';
 import { UnsignedProtocolCall } from '../../../wallet/adapters/ConcreteWallet';
 import { IProviderFactory } from '../../../wallet/adapters/IProviderFactory';
 import { AbstractContractCallGateway, ContractCallDetails } from '../AbstractContractCallGateway';
@@ -22,11 +23,11 @@ export class UpdateProfileManagersGateway
   implements ISignedOnChainGateway<UpdateProfileManagersRequest>
 {
   constructor(
-    logger: ILogger,
+    config: LensConfig,
     providerFactory: IProviderFactory,
     private apolloClient: SafeApolloClient,
   ) {
-    super(logger, providerFactory);
+    super(config, providerFactory);
   }
 
   async createUnsignedProtocolCall(