Fix: Support metrics for Pods with multiple containers #7866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnDaly
requested review from
ixrock and
Nokel81
and removed request for
a team
…ods that have multiple containers Signed-off-by: John Daly <[email protected]>
JohnDaly
force-pushed
the
fix/pod-container-metrics
branch
from
ce4ce2a
to
0025a7d
Compare
Nokel81
previously approved these changes
Jul 10, 2023
JohnDaly
commented
Jul 10, 2023
packages/core/src/renderer/components/workloads-pods/container-metrics.injectable.ts
Outdated
Show resolved
Hide resolved
…-metrics.injectable.ts Signed-off-by: John Daly <[email protected]>
Nokel81
approved these changes
Jul 11, 2023
|
@Nokel81 I think the failing test might be flaky. Can we try re-running the test? |
|
Can we get this merged, please? Thanks! |
|
@Nokel81 Is there anything else we need to do in order to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing the
containerprop fromPodDetailsContainerMetricstopodContainerMetricsInjectableso that we can query for metrics at thecontainerlevel.Fixes: #7854