22673 - Hide involuntary dissolution ledger item (bcgov#2931)

* 22673 - Hide involuntary dissolution ledger item

* refactored the code to make it cleaner

legal-api/src/legal_api/core/filing.py

@@ -460,7 +460,14 @@ def _add_ledger_order(filing: FilingStorage, ledger_filing: dict) -> dict:
     @staticmethod
     def _is_display_ledger(filing: FilingStorage) -> bool:
         """Return boolean that display the ledger."""
-        return filing.filing_type != Filing.FilingTypes.ADMIN_FREEZE
+        # If filing is NOT an admin freeze or involuntary dissolution, we will display it on ledger
+        return not (
+            filing.filing_type == Filing.FilingTypes.ADMIN_FREEZE or
+            (
+                filing.filing_type == Filing.FilingTypes.DISSOLUTION and
+                filing.filing_sub_type == 'involuntary'
+            )
+        )
 
     @staticmethod
     def get_document_list(business,  # pylint: disable=too-many-locals disable=too-many-branches

legal-api/tests/unit/core/test_filing_ledger.py

@@ -107,6 +107,13 @@ def test_common_ledger_items(session):
     assert common_ledger_items['documentsLink'] is not None
     assert common_ledger_items['displayLedger'] is True
 
+    filing['filing']['dissolution']['dissolutionType'] = 'involuntary'
+    completed_filing = \
+        factory_completed_filing(business, filing, filing_date=founding_date + datedelta.datedelta(months=1))
+    common_ledger_items = CoreFiling.common_ledger_items(identifier, completed_filing)
+    assert common_ledger_items['documentsLink'] is not None
+    assert common_ledger_items['displayLedger'] is False
+
     filing['filing']['header']['name'] = 'adminFreeze'
     completed_filing = \
         factory_completed_filing(business, filing, filing_date=founding_date + datedelta.datedelta(months=1), filing_type='adminFreeze')