-
-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Match Ubuntu NDK (21) to aarch64/M1 (25 rc2) #578
Draft
leotm
wants to merge
17
commits into
master
Choose a base branch
from
ci/ubuntu-ndk-25-rc2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Spotted in https://github.com/leotm/react-native-template-new-architecture/runs/6261011482?check_suite_focus=true#step:7:62 Missed in #276 Use Groovy variable later
This reverts commit 4369806.
11 tasks
leotm
added
the
ci
GitHub Actions workflow - Bundling / Building / Compiling / Integrating / Testing
label
Jun 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NDK 23 found (last 2 commits)
/usr/local/lib/android/sdk/ndk
: 21.4.7075529, 22.1.7171670, 23.1.7779620NDK 25 rc2 downloaded, not found
Ubuntu defaulting
ANDROID_NDK_HOME
:/usr/local/lib/android/sdk/ndk-bundle -> /usr/local/lib/android/sdk/ndk/21.4.7075529
ANDROID_NDK_ROOT
:/usr/local/lib/android/sdk/ndk-bundle -> /usr/local/lib/android/sdk/ndk/21.4.7075529
Solutions
rm -rf /usr/local/lib/android/sdk/ndk-bundle
- prevent side-by-side 21 detectionANDROID_NDK_HOME: ${{ steps.setup-ndk.outputs.ndk-path }}
, likely fail to find/usr/local/lib/android/sdk/ndk/25.x.x
ANDROID_NDK_HOME: ${{ steps.setup-ndk.outputs.ndk-path }}
should workcp -rf ${{ steps.setup-ndk.outputs.ndk-path }} /usr/local/lib/android/sdk/ndk/25.x.x
- should work toocp -rf ${{ steps.setup-ndk.outputs.ndk-path }} /usr/local/lib/android/sdk/ndk-bundle
- should work tooSpotted in https://github.com/leotm/react-native-template-new-architecture/runs/6261011482?check_suite_focus=true#step:7:62
Missed in #276
Use Groovy var later