Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation read through #219

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Documentation read through #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4c780cb
Minor changes to installation instructions
Oct 15, 2024
db7cfaa
Attempt to fix cppp coverage issue
Oct 15, 2024
42a7e8f
Attempting to fix code coverage error
Oct 15, 2024
77df555
Attempting to fix code coverage error with additional line
Oct 15, 2024
ce34fd1
revert testing test
Oct 15, 2024
ea8c2e5
Further attempt to fix coverage error
Oct 15, 2024
6195c88
Moving lcov stuff to other branch
Oct 15, 2024
b4d8b2d
Merge branch 'main' into issue/216/documentation-read-through
Oct 16, 2024
48b2277
Remove unnecesary installation line
Oct 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions docs/getting_started.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ LePHARE is distributed with `pypi <https://pypi.org/project/lephare/>`_, and thu

.. code-block:: bash

# We recommend using Python 3.12 which is the best tested
conda create -n <env_name> python=3.12
conda activate <env_name>
pip install lephare

.. note::
Expand Down Expand Up @@ -131,9 +134,8 @@ editable mode with the `-e` option so that any changes are immediately propagate

.. code-block:: bash

conda create env -n <env_name>
conda create -n <env_name> python=3.12
conda activate <env_name>
conda install cxx-compilers # May not be required for linux
git clone https://github.com/lephare-photoz/lephare.git
cd lephare
git submodule update --init --recursive
Expand All @@ -144,9 +146,8 @@ editable mode with the `-e` option so that any changes are immediately propagate

.. code-block:: bash

conda create env -n <env_name>
conda create -n <env_name> python=3.12
conda activate <env_name>
conda install cxx-compilers
brew install llvm libomp
git clone https://github.com/lephare-photoz/lephare.git
cd lephare
Expand Down
7 changes: 3 additions & 4 deletions src/lib/_bindings.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,10 +63,9 @@ PYBIND11_MODULE(_lephare, mod) {
"standard constructor")
.def_readwrite("lamb_opa", &opa::lamb_opa)
.def_readwrite("opared", &opa::red)
.def("read", &opa::read)
// .def("lmin", &opa::lmin, "return smallest wavelength stored")
// .def("lmax", &opa::lmax, "return largest wavelength stored")
;
.def("read", &opa::read);
// .def("lmin", &opa::lmin, "return smallest wavelength stored")
// .def("lmax", &opa::lmax, "return largest wavelength stored")

/******** CLASS EXT *********/
py::class_<ext>(mod, "ext")
Expand Down
Loading