Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused dependencies leptos_axum and leptos_router #2960

Merged
merged 4 commits into from
Oct 10, 2024

Conversation

vsuryamurthy
Copy link
Contributor

In the process of preparing for 0.7 (atleast for leptos_axum), some dependencies were added but unnecessary as axum re-exports them.

@gbj
Copy link
Collaborator

gbj commented Oct 2, 2024

Thanks for the PR. The CI was complaining about several things but I took too long to get to it, so I just fixed the cargo fmt issues and will let it run again.

@gbj
Copy link
Collaborator

gbj commented Oct 2, 2024

Just to add some clarification for the CI error, the issue here is that cargo check --no-default-features on leptos_axum.

@vsuryamurthy
Copy link
Contributor Author

There seems to be two more checks that fail. Should I just fix it although it doesnt seem to be this particular PR that is causing the fail?

@gbj
Copy link
Collaborator

gbj commented Oct 3, 2024

Unless I'm misunderstanding, the two checks that I see failing are integrations/axum failing cargo check --no-default-features (because of the changes in the PR) and hackernews_js_fetch (failing because it uses leptos_axum without default features).

@vsuryamurthy
Copy link
Contributor Author

Okay my bad, I see where it went wrong.

@benwis
Copy link
Contributor

benwis commented Oct 10, 2024

Thanks for working on this. It looks solid to reuse the axum exports here

@benwis benwis merged commit f0bcbd9 into leptos-rs:main Oct 10, 2024
73 checks passed
chrisp60 pushed a commit to chrisp60/leptos that referenced this pull request Oct 16, 2024
)

* remove unused dependencies leptos_axum and leptos_router

* cargo fmt

* Restore http::Uri under default feature

* use axum re-exported headers instead of http directly

---------

Co-authored-by: Greg Johnston <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants