refact: remove static methods from cast contracts

leroy-merlin-br · Oct 18, 2023 · 55acc80 · 55acc80
1 parent 60406ab
commit 55acc80
Show file tree

Hide file tree

Showing 7 changed files with 18 additions and 16 deletions.
diff --git a/src/Model/Casts/CastInterface.php b/src/Model/Casts/CastInterface.php
@@ -6,7 +6,7 @@
 
 interface CastInterface
 {
-    public static function get(mixed $value): mixed;
+    public function get(mixed $value): mixed;
 
-    public static function set(mixed $value): mixed;
+    public function set(mixed $value): mixed;
 }
diff --git a/src/Model/Casts/DateTime/BaseDateTimeCast.php b/src/Model/Casts/DateTime/BaseDateTimeCast.php
@@ -14,13 +14,13 @@ abstract class BaseDateTimeCast implements CastInterface
      * @param UTCDateTime|null $value
      * @return DateTimeInterface|null
      */
-    abstract public static function get(mixed $value): mixed;
+    abstract public function get(mixed $value): mixed;
 
     /**
      * @param DateTimeInterface|UTCDateTimeInterface|null $value
      * @return UTCDateTime|null
      */
-    public static function set(mixed $value): mixed
+    public function set(mixed $value): mixed
     {
         if (is_null($value)) {
             return null;

diff --git a/src/Model/Casts/DateTime/DateTimeCast.php b/src/Model/Casts/DateTime/DateTimeCast.php
@@ -12,10 +12,9 @@ class DateTimeCast extends BaseDateTimeCast
      * @param UTCDateTime|null $value
      * @return DateTime|null
      */
-    public static function get(mixed $value): mixed
+    public function get(mixed $value): mixed
     {
         if (is_null($value)) {
-
             return null;
         }
 

diff --git a/src/Model/Casts/DateTime/ImmutableDateTimeCast.php b/src/Model/Casts/DateTime/ImmutableDateTimeCast.php
@@ -12,7 +12,7 @@ class ImmutableDateTimeCast extends BaseDateTimeCast
      * @param UTCDateTime|null $value
      * @return DateTimeImmutable|null
      */
-    public static function get(mixed $value): mixed
+    public function get(mixed $value): mixed
     {
         if (is_null($value)) {
             return null;

diff --git a/tests/Unit/Model/Casts/DateTime/BaseDateTimeCastTest.php b/tests/Unit/Model/Casts/DateTime/BaseDateTimeCastTest.php
@@ -12,11 +12,12 @@ public function testShouldSet(): void
     {
         // Set
         $dateInDateTime = DateTime::createFromFormat('d/m/Y H:i:s', '08/10/2025 12:30:45');
+        $dateTimeCast = new DateTimeCast();
 
         // Actions
-        $expires_at = DateTimeCast::set($dateInDateTime);
-        $nulled_at = DateTimeCast::set(null);
-        $restored_at = DateTimeCast::set(
+        $expires_at = $dateTimeCast->set($dateInDateTime);
+        $nulled_at = $dateTimeCast->set(null);
+        $restored_at = $dateTimeCast->set(
             new UTCDateTime($dateInDateTime)
         );
 

diff --git a/tests/Unit/Model/Casts/DateTime/DateTimeCastTest.php b/tests/Unit/Model/Casts/DateTime/DateTimeCastTest.php
@@ -14,11 +14,12 @@ public function testShouldGet(): void
         $timestamp = new UTCDateTime(
             DateTime::createFromFormat('d/m/Y H:i:s', '08/10/2025 12:30:45')
         );
+        $dateTimeCast = new DateTimeCast();
 
         // Actions
-        $revoked_at = DateTimeCast::get(null);
-        $expires_at = DateTimeCast::get($timestamp);
-        $validated_at = DateTimeCast::get($timestamp);
+        $revoked_at = $dateTimeCast->get(null);
+        $expires_at = $dateTimeCast->get($timestamp);
+        $validated_at = $dateTimeCast->get($timestamp);
 
         // Assertions
         $this->assertNull($revoked_at);

diff --git a/tests/Unit/Model/Casts/DateTime/ImmutableDateTimeCastTest.php b/tests/Unit/Model/Casts/DateTime/ImmutableDateTimeCastTest.php
@@ -14,11 +14,12 @@ public function testShouldGet(): void
         $timestamp = new UTCDateTime(
             DateTimeImmutable::createFromFormat('d/m/Y H:i:s', '08/10/2025 12:30:45')
         );
+        $immutableDateTimeCast = new ImmutableDateTimeCast();
 
         // Actions
-        $revoked_at = ImmutableDateTimeCast::get(null);
-        $birthdate = ImmutableDateTimeCast::get($timestamp);
-        $created_at = ImmutableDateTimeCast::get($timestamp);
+        $revoked_at = $immutableDateTimeCast->get(null);
+        $birthdate = $immutableDateTimeCast->get($timestamp);
+        $created_at = $immutableDateTimeCast->get($timestamp);
 
         // Assertions
         $this->assertNull($revoked_at);