Skip to content

Commit

Permalink
chore: rename node23 ci
Browse files Browse the repository at this point in the history
  • Loading branch information
iChenLei committed Jan 7, 2025
1 parent e171c77 commit 45dfb50
Showing 1 changed file with 1 addition and 19 deletions.
20 changes: 1 addition & 19 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node: [14, 16, 18, 20]
node: [14, 16, 18, 20, 23]
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v2
Expand All @@ -74,21 +74,3 @@ jobs:
run: npx playwright install chromium
- name: Run unit test
run: npm run test

allow_failure_testing_for_node23:
name: 'Allow failure for nodejs v23 tests'
needs: basic_node_test
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: 23
- name: Install npm dependencies
run: npm install
- name: Print put node & npm version
run: node --version && npm --version
- name: Install chromium
run: npx playwright install chromium
- name: Run unit test
run: npm run test

0 comments on commit 45dfb50

Please sign in to comment.