-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Master fix 3622 #4298
base: master
Are you sure you want to change the base?
Master fix 3622 #4298
Conversation
this.value = node; | ||
}; | ||
|
||
ListParen.prototype = Object.assign(new Node(), { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've been working so long on a new Less parser that I didn't realize that the existing parser / node tree doesn't have a distinct "List" nor "SelectorList" class. It's weird to have "Paren" and "ListParen" as distinct classes vs "Paren" being a node that contains "List" as a single node, but with the current architecture, I guess this makes sense. The current node tree doesn't properly abstract the SelectorList in a way that is generalizable to these use cases.
What:
Contains fixes for a variety of syntax raised in #3622
Why:
Existing less code was too rigid and expected
)
where a list of selectors was possible.Checklist:
The following Less.js:
becomes the following CSS: