[P036] Add ticker as scroll option #4746
Conversation
…et_no_config_dat' into UweKaditz
|
@tonhuisman I checked my code with your PRs #4554 and #4722. |
That sounds like a smart plan 👍 |
…y, Start page updates after network has connected in PLUGIN_ONCE_A_SECOND BUG: Calculation for ticker IdxStart and IdxEnd was wrong for 64x48 display CHG: Start page updates after network has connected in PLUGIN_ONCE_A_SECOND, faster than waiting for the next PLUGIN_READ
- Individual font setting can only enlarge or maximize the font, if more than 1 line should be displayed (it was buggy not only for ticker!) - CalculateIndividualFontSettings() must be called until the font fits (it was buggy not only for ticker!) - Compiler error for '#ifdef P036_FONT_CALC_LOG'
|
|
||
| if (log1.reserve(140)) { // estimated | ||
| delay(10); // otherwise it is may be to fast for the serial monitor | ||
| log1.clear(); |
There was a problem hiding this comment.
delay()calls should be really required, or else limited to 1 msec,, and only to avoid the watchdog stepping in (after 30 seconds)- no need to
clear()a freshly declared String, that's already empty...
|
The Without the delay I encountered problems while writing debug messages to the serial output using Without delay: With a delay of 10 ms: |
|
@uwekaditz Can you fix the merge conflicts, so we can further test this code? |
|
I will solve the merge conflicts on Monday because over the weekend I'll be busy. |
The merge conflicts are soldved.
|
The intent is to enable this feature by default, so first I have to check if it wasn't defined already, to keep that setting (we're working on a build service where plugins, controllers and features can be selected, both on and off 😉)
That's a known 'feature' (wouldn't call it an 'issue' 🤔, as it's by design), the Devices page is updated (from a small piece of javascript in the page, so you should allow that to run...) with the frequency of the shortest Interval of all your active devices. |
|
Line 29 is fine, it's already |
|
Hmm, I'm looking at current |
I was wrong with my comment. |
…_WRITE) - Sometimes exception if the content was updated by an IR command (P016), but sending the command by Tools->Command->Submit never resulted in an exception! - Wrong eventId if new line content received - Typo in comment
Add ticker as scroll option, solves issue #4188
For the
Tickerthere are some restrictions:Interval)<|>is replaced by three spacesline content(tailing spaces)Align content (global)Modify fontof the first line, theAlignmentsettings of the lines are ignored (always right aligned)IntervalsettingSetting and support for
oledframedcmd,restore,<0|<nn>>subcommand par2: (0=all|Line Content)0|<nn>parameter is set to 0 all line contents will be restored from the settings.Setting and support for
oledframedcmd,scroll,<1..6>subcommand, par2: (casted to ePageScrollSpeeds)1..6parameter corresponds with the line number of the scroll parameter of the settings (1=Very slow ... 6=Ticker).Minor change in debug messages:
addLogMove()for dynamic messagesdelay(5)added if several debug message are issued in succession (the RS232 was too slow!)