Add Plugin for TE AmbiMate MS4 multi-sensor #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
February 5, 2019 23:06
… every 1 sec for better response), all other sensors are adjustable for time. This plugin will only read Temp/Humidity/Light and PIR sensor right now. For CO2/VOC/Audio level, I will either make a new plugin, or allow selection of sensors on the web config page.
|
Plugin has been tested against the latest ESPEasy release, and is working well! Tested with my Kube v2 (prototype livestream including testing here: https://youtu.be/eWV52eQ6LFQ) |
TD-er
reviewed
Feb 17, 2019
| } | ||
|
|
||
| // 100ms delay | ||
| delayBackground(100); |
There was a problem hiding this comment.
Why a delay here?
See the code of BME280 to get an idea of letting the plugin reschedule itself to be read when the sensor should be ready to give the processed values.
Delay will block the ESP to do other tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding TE AmbiMate MS4 multi-sensor plugin (Temp/Humidity/Light/Motion/CO2/VOC/Audio)
https://www.te.com/global-en/product-CAT-AM16-M8797.html