Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add orm for Tools and clean up Tool logic #1935

Merged
merged 36 commits into from
Oct 25, 2024
Merged

Conversation

mattzh72
Copy link
Collaborator

@mattzh72 mattzh72 commented Oct 24, 2024

Description

This is a large refactor of how Tools are being instantiated today.

  • We create a Tool ORM model and a corresponding Tool manager.
  • We change the Tool interface to require both user_id and organization_id on creation
  • We integrate these changes across all the surfaces in the codebase (there are many) that use Tools

@norton120 again credits for inspiring the orm model for tool

Testing

We write a suite of unit tests for the tool manager interface and also adapt existing tests to use our new interfaces.

@mattzh72 mattzh72 requested a review from sarahwooders October 24, 2024 22:53
@mattzh72 mattzh72 requested a review from sarahwooders October 25, 2024 20:58
Copy link
Collaborator

@sarahwooders sarahwooders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mattzh72 mattzh72 merged commit 6b330d7 into main Oct 25, 2024
12 of 13 checks passed
@sarahwooders sarahwooders deleted the matt-add-tool-orm branch January 29, 2025 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants