Added source directories in eclipse target, removed redundant targets #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lewismc
requested changes
Mar 29, 2023
build.gradle.kts
Outdated
| description = "create eclipse project files" | ||
| dependsOn("clean-eclipse", "init", "resolve-test", "job", "eclipse") | ||
| //test on variable | ||
| tasks.register("print-test") { |
build.gradle.kts
Outdated
| description = "--> create eclipse project files" | ||
|
|
||
| // not sure if any of this from ant needed | ||
| // <pathconvert property="eclipse.project"> |
build.gradle.kts
Outdated
| // <regexpmapper from="^.*/([^/]+)$$" to="\1" handledirsep="yes"/> | ||
| // </pathconvert> | ||
|
|
||
| // <taskdef name="eclipse" |
build.gradle.kts
Outdated
| // <classpath> | ||
| // <library path="${conf.dir}" exported="false" /> | ||
| // <library path="${basedir}/src/bin" exported="false" /> | ||
| // <library pathref="eclipse.classpath" exported="false" /> |
There was a problem hiding this comment.
Please see https://github.com/lewismc/nutch/blob/master/build.xml#L1158-L1170 and implement the equivalent using https://docs.gradle.org/current/dsl/org.gradle.plugins.ide.eclipse.model.EclipseClasspath.html
build.gradle.kts
Outdated
| // classname="prantl.ant.eclipse.EclipseTask" | ||
| // classpath="${build.dir}/lib/ant-eclipse-1.0-jvm1.2.jar" /> | ||
| // <eclipse updatealways="true"> | ||
| // <project name="${eclipse.project}" /> |
There was a problem hiding this comment.
…e exception of .gradle/cache)
…rrect order. Also added notes for adding lib jars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull requests on future development by Elliott and Simon