Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved hover support: Structs, qualified calls and types, more info for modules #356

Merged
merged 33 commits into from
Sep 22, 2023
Merged

Improved hover support: Structs, qualified calls and types, more info for modules #356

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
f69137a
Support struct hover
zachallaun Sep 2, 2023
f6cc0f8
Support for hovering qualified calls
zachallaun Sep 5, 2023
2321c40
Clean up `Lexical.RemoteControl.CodeIntelligence.Docs`
zachallaun Sep 5, 2023
c020e0d
Add `Lexical.Ast.is_call/2` guard
zachallaun Sep 5, 2023
392ae41
Return nil hover response for modules without moduledoc
zachallaun Sep 8, 2023
34e2e55
Include callbacks in module hover and fix `Ast` position finding
zachallaun Sep 12, 2023
0371755
Remove unnecessary hover assertion helper
zachallaun Sep 12, 2023
d0d8f57
Refactor markdown helpers into utility module
zachallaun Sep 12, 2023
7517e85
Return the entity range with hover responses
zachallaun Sep 15, 2023
48d8848
Show hover for module without moduledoc if there is other info to show
zachallaun Sep 15, 2023
0815f4b
Add vendored `Future.Code.Typespec` which includes spec fix
zachallaun Sep 15, 2023
201f422
Fix spec
zachallaun Sep 15, 2023
e74c754
Add hover support for qualified types
zachallaun Sep 15, 2023
6b44721
Include callback docs if present
zachallaun Sep 15, 2023
de36f18
Remove dead code
zachallaun Sep 15, 2023
9bfa9aa
Simplify `is_call` guard
zachallaun Sep 15, 2023
9592956
Move `:sourceror` dep to point at latest upstream commit
zachallaun Sep 15, 2023
3b68808
Remove old comment
zachallaun Sep 15, 2023
5327e47
Bump Sourceror and use its `is_call/1`
zachallaun Sep 17, 2023
4f2591f
Fix hover for qualified macros
zachallaun Sep 17, 2023
1258b5e
Improve `Lexical.Test.CursorSupport` API
zachallaun Sep 18, 2023
0bafbd8
Add tests for `Lexical.Ast.path_at/2`
zachallaun Sep 18, 2023
306b78e
Fix cache key typo in CI workflow
zachallaun Sep 18, 2023
9c899a6
Suggested changes from code review
zachallaun Sep 18, 2023
492ae8d
Remove most horizontal rules in hover markdown
zachallaun Sep 18, 2023
a960337
Fix resolving `__MODULE__` as a struct
zachallaun Sep 18, 2023
bc0b963
Rename `terminal_node?` to `leaf?`
zachallaun Sep 19, 2023
ef6e777
Bump Sourceror
zachallaun Sep 19, 2023
916c211
Add `RangeSupport.pop_range/1` and refactor `contains_position?/2` tests
zachallaun Sep 19, 2023
cfc3476
Make suggested changes from code review
zachallaun Sep 19, 2023
fb4d977
Use same formatting style in all entity tests
zachallaun Sep 21, 2023
bac214e
When resolving a struct, always resolve full alias
zachallaun Sep 21, 2023
d46b08f
Add additional test case for struct resolve
zachallaun Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/elixir.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ jobs:
id: set_mix_lock_hash
run: |
mix_lock_hash="${{ hashFiles(env.project_mix_lock) }}"
projects_hash="${{ hashFiles(env.project_ex_blob, env.projects_locks_blob) }}"
projects_hash="${{ hashFiles(env.projects_ex_blob, env.projects_locks_blob) }}"
echo "mix_lock_hash=$mix_lock_hash::$projects_hash" >> "$GITHUB_OUTPUT"

# Step: Define how to cache deps. Restores existing cache if present.
Expand Down
Loading
Loading