-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Symfony 7 #1165
Support Symfony 7 #1165
Conversation
Can this be merged? The CI issues are not related to this update. |
You need to update the GitHub Actions (CI) process to include the Symfony 7 version. Otherwise, tests are not being executed by using the expected SF version: https://github.com/lexik/LexikJWTAuthenticationBundle/blob/2.x/.github/workflows/ci.yml |
Updated the CI workflows accordingly. Apparently, support for 6.3 was still in dev mode. Do you really want to keep supporting unmaintained Symfony versions like 6.0, 6.1 and 6.2? Would make the CI a lot cleaner if we removed those. Also there are failing PHPUnit jobs unrelated to my changes, can you look into that? I don't see what is exactly going wrong. Regarding the upgrade to Symfony 7: this fails because of an API Platform incompatibility, maybe we better wait for that PR to be released first. |
This is something that (probably) the current maintainers will want to review themselves. I ended up in this PR because I posted an Issue requesting SF7 support.
The ones who have permission to merge will decide. I hope it won't take too long to merge this (or another) PR. |
Anyone with permission to merge had a look at this yet? Symfony 7 is about to be released and I'd like to know if any more effort / changes are needed. |
Sorry for the delay guys. |
Thank you @endroid. |
Adds support for Symfony 7.x