Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Symfony 7 #1165

Merged
merged 4 commits into from
Nov 25, 2023
Merged

Support Symfony 7 #1165

merged 4 commits into from
Nov 25, 2023

Conversation

endroid
Copy link
Contributor

@endroid endroid commented Nov 7, 2023

Adds support for Symfony 7.x

@endroid
Copy link
Contributor Author

endroid commented Nov 21, 2023

Can this be merged? The CI issues are not related to this update.

@DavidGarciaCat
Copy link

You need to update the GitHub Actions (CI) process to include the Symfony 7 version.

Otherwise, tests are not being executed by using the expected SF version:

https://github.com/lexik/LexikJWTAuthenticationBundle/blob/2.x/.github/workflows/ci.yml

@endroid
Copy link
Contributor Author

endroid commented Nov 22, 2023

Updated the CI workflows accordingly. Apparently, support for 6.3 was still in dev mode. Do you really want to keep supporting unmaintained Symfony versions like 6.0, 6.1 and 6.2? Would make the CI a lot cleaner if we removed those. Also there are failing PHPUnit jobs unrelated to my changes, can you look into that? I don't see what is exactly going wrong.

Regarding the upgrade to Symfony 7: this fails because of an API Platform incompatibility, maybe we better wait for that PR to be released first.

@DavidGarciaCat
Copy link

Updated the CI workflows accordingly. Apparently, support for 6.3 was still in dev mode. Do you really want to keep supporting unmaintained Symfony versions like 6.0, 6.1 and 6.2? Would make the CI a lot cleaner if we removed those. Also there are failing PHPUnit jobs unrelated to my changes, can you look into that? I don't see what is exactly going wrong.

This is something that (probably) the current maintainers will want to review themselves. I ended up in this PR because I posted an Issue requesting SF7 support.

Regarding the upgrade to Symfony 7: this fails because of an API Platform incompatibility, maybe we better wait for that PR to be released first.

The ones who have permission to merge will decide. I hope it won't take too long to merge this (or another) PR.

@endroid
Copy link
Contributor Author

endroid commented Nov 24, 2023

Anyone with permission to merge had a look at this yet? Symfony 7 is about to be released and I'd like to know if any more effort / changes are needed.

@chalasr
Copy link
Collaborator

chalasr commented Nov 25, 2023

Sorry for the delay guys.
I pushed a few changes to fix the broken tests on Symfony 7.0 and skipped installing api-platform there as it is blocking by now, PR welcome to add it again once it is 7.0-ready. And help welcome to actually make it 7.0-ready.
Also yes, we'll remove support for some of the oldest Symfony we have in an upcoming version, but not right now as I still need to determine if it should be done in the upcoming 3.x rather than 2.x.

@chalasr
Copy link
Collaborator

chalasr commented Nov 25, 2023

Thank you @endroid.

@chalasr chalasr merged commit 3b02f52 into lexik:2.x Nov 25, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants