-
-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for partitioned cookies #1167
Conversation
The CI pipeline errors seem to be unrelated to this PR's changes, and should probably be dealt with in a different PR. I checked other recent PRs and they are all getting this same error, which seems related to an updated dependency. --- Expected
+++ Actual
@@ @@
"title": "LexikJWTAuthenticationBundle",
"version": "1.0.0"
},
- "openapi": "3.0.0",
+ "openapi": "3.1.0",
"paths": {
"/login_check": {
"parameters": [],
/home/runner/work/LexikJWTAuthenticationBundle/LexikJWTAuthenticationBundle/Tests/Functional/Command/ApiPlatformOpenApiExportCommandTest.php:28
FAILURES!
Tests: 166, Assertions: 483, Failures: 1, Skipped: 22. |
Hello! Would it be possible to know when we can expect this to be reviewed and/or merged? |
b32b4fe
to
b2c5f99
Compare
Freshly rebased to get the Symfony 7 tests and the OpenAPI 3.1 update that fixes the CI pipeline errors :) |
@EmilePerron Awesome. One thing: given the feature can only be used on Symfony 6.4 and higher, should we throw an exception if ones tries to use it with an lower Symfony version? If it makes sense, I'd suggest throwing both from the DI Extension (when setting the option) and the CookieProvider constructor (for potential direct instantiation). |
|
a677b38
to
2d1d058
Compare
Thank you @EmilePerron. |
This PR adds support for partitioned third-party cookies in a backwards compatible way, as described in #1166.
I have updated the documentation's configuration examples, but have not added any tests regarding this new option as the existing tests did not seem to cover similar options. I'll gladly add some if you think it's worth it.
Let me know if you have any comments/feedback!
closes #1166