Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed constructor property promotion to fix compatibility with PHP 7.x #1172

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Removed constructor property promotion to fix compatibility with PHP 7.x #1172

merged 1 commit into from
Dec 1, 2023

Conversation

webhdx
Copy link
Contributor

@webhdx webhdx commented Dec 1, 2023

Looks like #1041 introduced PHP 7.x incompatible change. The issue is constructor property promotion in \Lexik\Bundle\JWTAuthenticationBundle\Command\EnableEncryptionConfigCommand class.

@webhdx webhdx mentioned this pull request Dec 1, 2023
Closed
@janek-papryka
Copy link

Closes #1173

@chalasr
Copy link
Collaborator

chalasr commented Dec 1, 2023

Thanks for the PR and thanks to reviewers!

@chalasr
Copy link
Collaborator

chalasr commented Dec 1, 2023

Good catch, thanks @webhdx.

@chalasr chalasr merged commit a3f124d into lexik:2.x Dec 1, 2023
10 checks passed
@webhdx webhdx deleted the patch-1 branch December 1, 2023 12:07
@chalasr
Copy link
Collaborator

chalasr commented Dec 1, 2023

Released https://github.com/lexik/LexikJWTAuthenticationBundle/releases/tag/v2.20.1

@webhdx
Copy link
Contributor Author

webhdx commented Dec 1, 2023

Thank you @chalasr!

@fracsi fracsi mentioned this pull request Dec 1, 2023
Merged
chalasr added a commit that referenced this pull request Dec 2, 2023
@chalasr
bug #1174 Fix for PHP <7.4 compatibility (fracsi)
236a180 
This PR was merged into the 2.x branch.

Discussion
----------

Fix for PHP <7.4 compatibility

Typed properties are only allowed since PHP 7.4.
Fixes #1173 for PHP <7.4
Follow up for #1172

Commits
-------

287a079 PHP <7.4 compatibility
@mnocon mnocon mentioned this pull request Dec 4, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhelias maxhelias maxhelias approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@webhdx @janek-papryka @chalasr @maxhelias