Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with angularjs 1.8.x #444

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

raziel057
Copy link
Contributor

The component doesn't works with AngularJs > 1.5.x:

The $http legacy promise methods success and error have been deprecated in 1.5.x and is removed in v1.6.0.
So we got the following error: TypeError: $http.get(...).success is not a function

See : https://code.angularjs.org/1.5.11/docs/api/ng/service/$http#get

As suggested we need to use the standard then method instead.

@raziel057
Copy link
Contributor Author

Hi there,

I'm a bit confused that this PR is not yet accepted knowing that the component relay on angularJs 1.8 by default since commit ed737c5

So currently it lead to JS errors related to translation.js when using angularJs > 1.6.0.

For the context:
image

Would it be possible to merge it in master and 6.0 branch?

@bartmcleod
Copy link
Collaborator

@raziel057 I simply didn't have time, it looks perfectly allright to me, there are conflicts though, is it possible this was already fixed when I did some frontend fixes for SF 7? Can you maybe solve the conflicts? And feel free to make a PR to the 6.0 branch as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants