Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for keyword lists in tags #24

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hauleth
Copy link

@hauleth hauleth commented Apr 12, 2018

Closes #23

Copy link
Owner

@lexmag lexmag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still not sure if this is something that should be included for the following reasons:

  1. StatsD protocol does not have key-value tags concept, perhaps it would be better to keep Statix aligned with the protocol
  2. not everything implements String.Chars and ultimately only user knows how to cast their data to string

@hauleth
Copy link
Author

hauleth commented Apr 18, 2018

  1. StatsD do not support tags at all, not even comments (which would provide compatibility layer) so I do not think this is a problem.
  2. I wouldn't say this is a problem either. However if this is a problem I can add limits to support only strings and atoms in lists/maps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accept keyword list as a tags
2 participants