Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation #37

Merged
merged 17 commits into from
Dec 2, 2024
Merged

Documentation #37

merged 17 commits into from
Dec 2, 2024

Conversation

stroblme
Copy link
Collaborator

@stroblme stroblme commented Nov 15, 2024

This PR should resolve #36:

  • update README (visualization, getting started)
  • update CONTRIBUTING (documentation,..)
  • check docstrings

Melvin Strobl added 2 commits November 15, 2024 11:09
Signed-off-by: Melvin Strobl <[email protected]>
gc
Signed-off-by: Melvin Strobl <[email protected]>
@stroblme stroblme changed the title Documentation [DRAFT] Documentation Nov 15, 2024
@stroblme
Copy link
Collaborator Author

When doing a fresh install and running kedro viz, I'm getting an import error in qallse that trackml.score_event is not available. @majafranz, could you verify that?

@majafranz
Copy link
Member

When doing a fresh install and running kedro viz, I'm getting an import error in qallse that trackml.score_event is not available. @majafranz, could you verify that?

I think we (or actually qallse) still need the trackml dependency. As it is not released on Pypi, we could try to install it via the GitHub Repo, either in this repo, or in our fork of qallse.

@stroblme
Copy link
Collaborator Author

thanks! I would prefer the second option. As we already have a fork, and qallse is tightly bound to trackml, I feel like this would be the cleanest solution

lc3267 added 3 commits November 18, 2024 21:01
@stroblme
Copy link
Collaborator Author

resolved, I just started a transfer to your repo @majafranz ; maybe you could in turn then transfer it to lfd, then we have all in one place :)

@majafranz
Copy link
Member

resolved, I just started a transfer to your repo @majafranz ; maybe you could in turn then transfer it to lfd, then we have all in one place :)

Thanks! This should work now, after updating the submodules.

Melvin Strobl added 4 commits November 19, 2024 10:34
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
gc
Signed-off-by: Melvin Strobl <[email protected]>
@stroblme stroblme changed the title [DRAFT] Documentation Documentation Nov 19, 2024
Melvin Strobl added 7 commits November 19, 2024 11:10
gc
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
Signed-off-by: Melvin Strobl <[email protected]>
qa
Signed-off-by: Melvin Strobl <[email protected]>
@stroblme stroblme requested a review from majafranz December 2, 2024 07:53
Copy link
Member

@majafranz majafranz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! 🚀

@majafranz majafranz merged commit 081808b into main Dec 2, 2024
1 check passed
@majafranz majafranz deleted the documentation branch December 2, 2024 08:21
@stroblme stroblme mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cleanup & Documentation
2 participants