Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hard bounds #41

Merged
merged 7 commits into from
Dec 5, 2024
Merged

Hard bounds #41

merged 7 commits into from
Dec 5, 2024

Conversation

majafranz
Copy link
Member

This PR adresses that specifying bounds for the FOURIER coefficient does not really make sense.
Instead, now, when applying bounds with the FOURIER strategy, hard limits for beta and gamma parameters are set after applying the sine and cosine transformations.
Resulting parameters are in $\beta \in [-\pi / 2, \pi / 2]^p$ and $\gamma \in [0, \pi ]^p$.
If a $\gamma$ parameters is negative, we account for the QAOA symmetries, by flipping the sign of the respective gamma and beta parameter.

Example:
If the $v$ and $u$ parameters result in a gamma parameter of $\gamma_1=-5$, and a beta parameter of $\beta_1=1$ applying the bound results in $\gamma_{1,b}=\pi$ and $\beta_{1, b} = -1$, through flipping and applying bounds.

Additionally, parameters are also normalised according to bounds and symmetries, when computing the annealing schedules from the parameters.

@majafranz majafranz requested a review from stroblme December 4, 2024 11:50
Copy link
Collaborator

@stroblme stroblme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the great work! I left a comment but nothing severe.
Also I'll add a commit regarding the default values for the cost fkt.
Because it's an inner fct, I don't think that we need default values here?

@majafranz majafranz merged commit 339189c into main Dec 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants