Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/assert is owner #19

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Fix/assert is owner #19

merged 3 commits into from
Jan 10, 2024

Conversation

Th0rgal
Copy link
Member

@Th0rgal Th0rgal commented Jan 8, 2024

This pull request closes lfglabs-dev/app.starknet.id#627

It fixes a check on the parent key to ensure that if you owned a domain whose parent was reset, you no longer own it.

@Th0rgal Th0rgal added the 🔥 Ready for review Pull Request needs a label Jan 8, 2024
@Th0rgal Th0rgal requested a review from irisdv January 8, 2024 16:32
@Th0rgal Th0rgal self-assigned this Jan 8, 2024
Copy link
Collaborator

@irisdv irisdv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just left a small comment, other than that it lgtm

@@ -27,7 +29,7 @@ use openzeppelin::token::erc20::interface::{
};
use integer::{u256_safe_divmod, u256_as_non_zero};
use naming::naming::utils::UtilsTrait;

use debug::PrintTrait;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be removed

@Th0rgal Th0rgal merged commit b327ec1 into master Jan 10, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔥 Ready for review Pull Request needs a
Projects
None yet
Development

Successfully merging this pull request may close these issues.

E2E: Reset subdomains
2 participants