Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for prefix type matching #57

Merged
merged 1 commit into from
Dec 28, 2024
Merged

Adds support for prefix type matching #57

merged 1 commit into from
Dec 28, 2024

Conversation

dylon
Copy link
Collaborator

@dylon dylon commented Dec 27, 2024

Changes:

  • Adds support for extracting prefix type queries and highlighting them.
  • Adds tests to ensure prefix and suffix type matching works.

@dylon
Adds logic to match against type prefixes on strings; adds tests that…
1aef7e2 
… ensure the query extractor and highlighter work against type prefixes and suffixes
certik
certik approved these changes Dec 28, 2024
View reviewed changes
Copy link
Contributor

@certik certik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's fine. Shouldn't ultimately LFortran provide the tokens with proper types?

@dylon
Copy link
Collaborator Author

dylon commented Dec 28, 2024

I think it's fine. Shouldn't ultimately LFortran provide the tokens with proper types?

Yes, I will migrate it to lfortran as soon as I can. My main concern, at the moment, is to ensure that customer's have a good experience with our extension.

@dylon dylon merged commit 93de79b into lfortran:main Dec 28, 2024
5 checks passed
@dylon dylon deleted the dylon/prefix-suffix-types branch December 28, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@certik certik certik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylon @certik