Add env variables CALCURSE_CALDAV_DATA_DIR and CALCURSE_CALDAV_CONFIG_DIR #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows users to set arbitrary locations for caldav config and data, without the calcurse-caldav script creating unused `caldav` directories inside $XDG_DATA_HOME/calcurse and $XDG_CONFIG_HOME/calcurse.
josephmturner
changed the title
|
Thanks for your contribution, Joseph! If I'm not mistaken, all paths can already be configured using command-line arguments (--config, --hookdir, ...) is there anything that's not covered by them? You're correct that using them will still lead to standard directories being generated to check_dir() calls. I think we should move the check_dir() calls to a later point in the script, after command line arguments have been parsed. Does that make sense? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows users to set arbitrary locations for caldav config and data,
without the calcurse-caldav script creating unused
caldavdirectoriesinside $XDG_DATA_HOME/calcurse and $XDG_CONFIG_HOME/calcurse.
Addresses #393