Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose keep_excessive_supervision parameter #1077

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nshmyrev
Copy link

Currently when supervision is slightly longer than recording user gets very confusing message about multiple channels:

Trimmed cut has supervisions with different channels. Either set keep_all_channels=True to keep original channels or keep_overlapping=False to retain only 1 supervision per trimmed cut.

This is because keep_overlapping is False and thus we filter out those bad supervisions. And keep_overalapping actually has nothing about the problem of wrong supervision times. One better expose keep_excessive_supervision parameter to method and provide more straightforward assert message.

@desh2608
Copy link
Collaborator

I think it may be better to first use fix_manifests() from lhotse/qa.py, instead of this. Then the longer supervisions will be trimmed to the recording length.

@pzelasko
Copy link
Collaborator

I agree with Desh, I'd rather not add support for supervision.duration > recording.duration, as it can be easily auto-fixed. We could emit a cleaner error message though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants