Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Tolerance to Floating Point Comparisons in find_intersection() #3497

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from
Open

Add Tolerance to Floating Point Comparisons in find_intersection() #3497

wants to merge 3 commits into from

Commits on Jun 22, 2023

  1. add random shifts to find_intersection() 

    closes libMesh#3496
    @miaoyinb
    miaoyinb committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    0197257 View commit details
    Browse the repository at this point in the history

  2. New unit test 

    This fails for me on master, and works for me with the new patch, so
hopefully it'll be a reliable way of making sure that any improved code
doesn't revert the fix.
    @roystgnr @miaoyinb
    roystgnr authored and miaoyinb committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    57bab4b View commit details
    Browse the repository at this point in the history

  3. Unit tests for "tangent" ray/hole intersection

    @roystgnr @miaoyinb
    roystgnr authored and miaoyinb committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    2566914 View commit details
    Browse the repository at this point in the history