Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS Java version validation #218

Merged

Conversation

raeleus
Copy link
Contributor

@raeleus raeleus commented Jan 19, 2025

Resolves #217
Instead of filtering the text that is inputted, prevent project generation and display an error message.

Copy link
Member

@tommyettinger tommyettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! There's even effects on the error message! I was expecting some scene2d.ui madness, I am glad this was code I can understand. Merging!

@tommyettinger tommyettinger merged commit e31fa4c into libgdx:master Jan 19, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SettingsPanel's Java Version handling (when iOS platform included) is unintuitive
2 participants