Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase length of segments removed by BufferOp short segment removal heuristic #1200

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

dr-jts
Copy link
Contributor

@dr-jts dr-jts commented Nov 20, 2024

The buffer algorithm removes very short segments from generated offset curves to improve robustness and output quality.
This increases the length of segment that is removed (from tiny to veryvery short).

CURVE_VERTEX_SNAP_DISTANCE_FACTOR = 1.0E-4;  // before was 1.0E-6

Fixes #1125

@dr-jts dr-jts added the Enhancement New feature or feature improvement. label Nov 20, 2024
@dr-jts dr-jts changed the title Improve buffer short segment removal Increase length of segments removed by BufferOp short segment removal heuristic Nov 20, 2024
@dr-jts dr-jts merged commit b002e8d into libgeos:main Nov 20, 2024
28 checks passed
@dr-jts dr-jts deleted the fix-buffer-short-seg-heuristic branch November 20, 2024 23:56
dr-jts added a commit that referenced this pull request Nov 21, 2024
dr-jts added a commit that referenced this pull request Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or feature improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Polygon buffer loses hole when quadSegs = 0
1 participant