Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poetry migration #370

Closed
wants to merge 6 commits into from
Closed

Poetry migration #370

wants to merge 6 commits into from

Commits on Jan 2, 2024

  1. Use poetry for dependency management 

    I made the configuration that can be used insted of setup.py. One of the reasons I decided to do that is because setup.py doesn't have the versions of the dependencies and the state of the project can't be perfectly replicated without knowing the versions.
    @Ovsyanka
    Ovsyanka committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    e7d1711 View commit details
    Browse the repository at this point in the history

  2. Use poetry for project building 

    Direct invocation of setup.py is [deprecated](https://blog.ganssle.io/articles/2021/10/setup-py-deprecated.html), so I replace it with using poetry.
    @Ovsyanka
    Ovsyanka committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    425640e View commit details
    Browse the repository at this point in the history

  3. Move package version to pyproject.toml 

    I removed `version` from the `init.py` because it would require to use some library like [importlib.metadata](https://docs.python.org/3/library/importlib.metadata.html) (available from python 3.8) to get version from the package metadata and there could be different options depending on the python version. As I understand, the library by itself doen't need that functionality and if someone who uses the library wants to get it's version he can use such a library instead of `pykeepass.version`

As it was used in the `make pypi` command, I made it upload all new releases to the PyPI instead of just current one. Probably twine will be replaced by `poetry publish` in the future anyway.
    @Ovsyanka
    Ovsyanka committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    9bc293c View commit details
    Browse the repository at this point in the history

  4. Remove obsolete files 

    requirements-rtd.txt, requirements.txt, and setup.py isn't used anymore
    @Ovsyanka
    Ovsyanka committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    749b9df View commit details
    Browse the repository at this point in the history

  5. Documentation update about tests running

    @Ovsyanka
    Ovsyanka committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    75918db View commit details
    Browse the repository at this point in the history

  6. Update github CI to use poetry

    @Ovsyanka
    Ovsyanka committed Jan 2, 2024
    Configuration menu
    Copy the full SHA
    fce6f8c View commit details
    Browse the repository at this point in the history