Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dtypes #629

Draft
wants to merge 24 commits into
base: development
Choose a base branch
from
Draft

Conversation

noelchalmers
Copy link
Contributor

Description

SFrijters and others added 24 commits August 15, 2022 12:01
* Update the namespace for features accepted into the SYCL 2020 spec.
* Replace deprecated barrier calls with `group_barrier`.
This behaviour was changed for CUDA in the v1.3 release, but getting e.g.
information about register spilling is very useful.

Also implement similar behaviour for HIP and Metal.
* Format OpenCL variable names to match CMake find_package convention.
* Updates search procedure for OpenCL headers and libraries.
* Report exit code when compiler invocation fails
* Make DPCPP and Metal compileKernel output more consistent with other modes
* Check whether popen actually returns a stream
…v var (libocca#622)

* Make compiler_flags setting take precedence over the compiler flag env var

* Apply same change to SYCL backend.
* [CUDA][HIP][OpenCL] Fix some warnings with gcc11

* [HIP]{OpenCL] Fix a couple more warnings
* API hooks for memoryPool

* [MemPool] Internal hooks for memoryPool

* [MemPool][CUDA] CUDA memoryPool

* [MemPool][Serial] Serial Memory pool

* [MemPool][HIP] HIP Memory Pool

* [MemPool][SYCL] SYCL Memory Pool

* [MemPool][OpenCL] OpenCL Memory Pool

* [MemPool][Metal] Metal Memory Pool

* [MemPool][Tests] Adding test for memoryPool

* [Core][MemPool] Fix compiler warnings

* [Buffer][MemoryPool] Fixing incorrect behavior of manual freeing of occa::memory

* [HIP] Address some compiler warnings

* [MemoryPool] Add missing override

* [MemPool] Put memoryPool object in experimental namespace

* [MemPool] Add a ShrinkToFit API

* [MemPool] Fix an issue with releasing reservation

* [Examples][Mempool] Add an example of memory pool usage

* [OpenCL] Fix an uninitialized varible warning

* [CI] Remove parallel ctest args

* [CI] Remove memory pool example from OpenCL test

* [MemPool] Move some mempool routines to a more centralized place

* [Examples] Change mempool example to have stronger error checking

* [Metal] Fix some memcpy offsets

* [MemPool] Add alignment options to mempool

* [MemPool] Update memPool example

* [MemPool] Fix warning

* [MemPool] Fix some more warnings

* [MemPool] More warnings

* [MemPool] Fixes for MemPool unit test

* [MemPool] Fix a signed-unsigned comparison

* [Core] Fix up when/where modeMemory and modeBuffers are deleted

* [Core][C][MemPool] Add C API for MemoryPools

* [Core][C][MemPool] Add src files for C API for MemoryPools

* [Tests][C][MemPool] Adding test for MemoryPool C API

* [Examples] Skip other modes for memory pool example

* [Buffer] Fix access rights to members of buffer classes

* [Buffer] Undo buffer::malloc needing a const argument
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #629 (f63ef37) into development (2e576e6) will decrease coverage by 0.45%.
Report is 61 commits behind head on development.
The diff coverage is 62.17%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #629      +/-   ##
===============================================
- Coverage        77.31%   76.87%   -0.45%     
===============================================
  Files              265      272       +7     
  Lines            19592    20013     +421     
===============================================
+ Hits             15148    15384     +236     
- Misses            4444     4629     +185     
Files Changed Coverage Δ
include/occa/types/json.hpp 75.26% <ø> (ø)
src/c/device.cpp 89.06% <0.00%> (-5.94%) ⬇️
src/c/dtype.cpp 70.58% <ø> (ø)
src/dtype/builtins.cpp 45.94% <0.00%> (-1.28%) ⬇️
src/occa/internal/core/buffer.cpp 100.00% <ø> (ø)
src/occa/internal/core/buffer.hpp 0.00% <0.00%> (ø)
src/occa/internal/lang/kernelMetadata.cpp 91.42% <0.00%> (ø)
src/occa/internal/lang/modes/serial.cpp 29.38% <0.00%> (-12.23%) ⬇️
src/occa/internal/lang/type/class.cpp 0.00% <0.00%> (ø)
src/occa/internal/lang/type/enum.cpp 0.00% <0.00%> (ø)
... and 25 more

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants