Improve user-definable max number of kernel arguments and automatic code generation. #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deukhyun-cha
force-pushed
the
n-kernel-args-update
branch
from
59a9340
to
18fb5d2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #725 +/- ##
============================================
Coverage 75.24% 75.25%
============================================
Files 297 297
Lines 19326 19327 +1
============================================
+ Hits 14542 14544 +2
+ Misses 4784 4783 -1
|
…sary. Add an option to only generate jit kernel related code for the new number of kernel arguments and leave others to the default value for compile time efficiency
deukhyun-cha
force-pushed
the
n-kernel-args-update
branch
from
04f3ffd
to
a788bbe
Compare
|
For the build with Makefile, it copies the default *codegen files in the script directory back to proper places in source tree, so it can compile (while the cmake will copy those into build directory and include them from there). |
kris-rowe
pushed a commit
that referenced
this pull request
Jan 24, 2024
…sary. Add an option to only generate jit kernel related code for the new number of kernel arguments and leave others to the default value for compile time efficiency (#725)
kris-rowe
pushed a commit
that referenced
this pull request
Mar 12, 2024
…sary. Add an option to only generate jit kernel related code for the new number of kernel arguments and leave others to the default value for compile time efficiency (#725)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update fixes an issue that each cmake configuration triggers automatic code generation without any changes in cmake options when a user-defined maximum number of kernel arguments is specified. Also added a cmake option that user can specify to generate codes for JIT kernel launch only if one knows that's what is going to be used, so it wouldn't suffer from longer compile time when a large value for the maximum number of kernel arguments is required.