Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A couple of Examples/concurrency #736

Closed
wants to merge 22 commits into from
Closed

A couple of Examples/concurrency #736

wants to merge 22 commits into from

Conversation

deukhyun-cha
Copy link
Contributor

Examples for 1) OpenMP streams to generalize the "stream" concept for all modes 2) Internal thread safe block for occa properties.

deukhyun-cha and others added 22 commits November 22, 2023 11:28
@deukhyun-cha
Allow user to define the maximum number of kernel arguments and autom…
2eae23b 
…atically run script to generate the codes (#718)
@kris-rowe
Hotfix GitHub Actions
c42a185 
The environment variable `SYCL_DEVICE_FILTER` used by the oneAPI SDK is deprecated, causing some tests to fail.
@kris-rowe
Remove dpcpp from modes tested with inline kernel example on GitHub (#…
f92bf81 
…719)
@kris-rowe
Sets OCCA_<MODE>_ENABLED in CMake parent scope. (#720)
9e86ae7 
Intended for CMake builds which add occa as a subdirectory.
@kris-rowe
Correctly sync all streams in device::finishAll(). (#723)
b0c3227
@kris-rowe
Ensure all work is complete on device before freeing memory. (#724)
5285d7b
@AljenU
cmake: Small fix to prevent empty module path (#694)
ff6e4ea
@deukhyun-cha
Update cmake to generate kernel-arguments-related codes only if neces…
3612b5d 
…sary. Add an option to only generate jit kernel related code for the new number of kernel arguments and leave others to the default value for compile time efficiency (#725)
@kris-rowe
Fixes corruption of memory datatypes caused by short circuit logic in…
5226290 
… `modeMemory_t::slice` (#727)
@kris-rowe
Refactor OpenCL mode and update CI testing (#730)
8957558 
* Refactor OpenCL utilities and device creation.

* Update OpenCL default device type.

* Only run math function test for active modes.

* Update GitHub workflows.

* Remove OpenCL from math function tests.
@kris-rowe
Set SYCL subgroup size via kernel property or @simd_length attribut…
66ae951 
…e. (#726)
@kris-rowe
**BREAKING** Make memory copies data type aware for consistency. (#728)
ce6f23c
@kris-rowe
**BREAKING** Return the number of dtype entries from `memory::size(…
c17644b 
…)`. (#711)
@noelchalmers
Initial support for compiler attribute statements (#729)
7a364ea
@kris-rowe
Prefix CMake build options with OCCA (#733)
7c2fe69
@kris-rowe
Update year.
495d314
@kris-rowe
Update version number.
08db185
@kris-rowe
Update minimum CMake version listed in docs.
62ca3a9
@kris-rowe
Rename memcpy free function length parameter to reflect changes to
ec9d90c 
`occa::memory`.
@kris-rowe
Move memoryPool from occa::experimental to occa namespace
6390b2d
@kris-rowe @deukhyun-cha
Initial placeholder for concurrency support examples.
09cfb8c
@deukhyun-cha
1) Adding examples for OpenMP-stream and threadsafe-device. 2) Updati…
519d104 
…ng concurrency example compilable
@deukhyun-cha
Copy link
Contributor Author

  • Created as a draft for any discussion before (or to decide) a merge.
  • The original examples/concurrency branch seems behind for some commits from the development and needs to catch up.

@codecov Codecov
Copy link

codecov bot commented Jan 24, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 55.41126% with 103 lines in your changes missing coverage. Please review.

Project coverage is 74.96%. Comparing base (ec6e59d) to head (519d104).
Report is 21 commits behind head on examples/concurrency.

Files Patch % Lines
src/occa/internal/lang/qualifier.cpp 29.23% 46 Missing ⚠️
src/occa/internal/lang/loaders/typeLoader.cpp 39.39% 20 Missing ⚠️
src/occa/internal/lang/modes/dpcpp.cpp 75.00% 11 Missing ⚠️
...a/internal/lang/builtins/attributes/simdLength.cpp 50.00% 10 Missing ⚠️
src/occa/internal/core/device.cpp 0.00% 5 Missing ⚠️
src/occa/internal/lang/type/vartype.cpp 0.00% 4 Missing ⚠️
src/occa/internal/lang/variable.cpp 0.00% 4 Missing ⚠️
include/occa/functional/array.hpp 88.88% 1 Missing ⚠️
src/c/device.cpp 0.00% 1 Missing ⚠️
src/occa/internal/c/types.cpp 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                    @@
##           examples/concurrency     #736      +/-   ##
========================================================
- Coverage                 75.26%   74.96%   -0.30%     
========================================================
  Files                       297      298       +1     
  Lines                     19324    19486     +162     
========================================================
+ Hits                      14544    14608      +64     
- Misses                     4780     4878      +98
Files Coverage Δ
include/occa/core/memoryPool.tpp 100.00% <ø> (ø)
include/occa/functional/typelessArray.hpp 73.49% <100.00%> (ø)
src/c/base.cpp 85.71% <100.00%> (ø)
src/c/memoryPool.cpp 87.87% <100.00%> (ø)
src/core/base.cpp 72.82% <100.00%> (+2.17%) ⬆️
src/core/kernel.cpp 85.93% <ø> (ø)
src/core/memory.cpp 84.71% <100.00%> (+1.38%) ⬆️
src/occa/internal/core/device.hpp 100.00% <ø> (ø)
src/occa/internal/core/memory.cpp 100.00% <ø> (ø)
src/occa/internal/core/memoryPool.cpp 68.58% <ø> (ø)
... and 18 more

... and 3 files with indirect coverage changes

@deukhyun-cha deukhyun-cha marked this pull request as ready for review March 19, 2024 13:28
@deukhyun-cha deukhyun-cha closed this by deleting the head repository Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@deukhyun-cha @kris-rowe @AljenU @noelchalmers