PWX-36873: Add vault cooldowns #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* double "permission denied" REST error will put vault client into 5 minutes cooldown for all REST calls * can disable via `VAULT_COOLDOWN_PERIOD:disabled` Signed-off-by: Zoran Rajic <[email protected]>
|
Note, @adityadani , @CharudathGopal -- looks like the
|
|
Woops.. forgot to include UT with the original commit (fixed w/ follow-up f9fde71) |
This reverts commit 3aaff8a -- cause this breaks other integration tests.
|
Ok.. I can't failing I'll proceed w/ the squash-commit. |
zoxpx
added a commit
that referenced
this pull request
Apr 16, 2024
* double "permission denied" REST error will put vault client into 5 minutes cooldown for all REST calls * can disable via `VAULT_COOLDOWN_PERIOD:0` Signed-off-by: Zoran Rajic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VAULT_COOLDOWN_PERIOD:disabledWhat this PR does / why we need it:
Turns out it is easy to overwhelm Hasicorp's Vault, and accidentally cause DDOS-attack
As a fix, we're adding
REST cooldownfor 5 minutes, to all Vault REST client callsPUT<key>++RENEW<token>both responded w/ "permission denied")Which issue(s) this PR fixes (optional)
Closes # PWX-36873
Special notes for your reviewer: