Add CleanupResources flag to migration specs

- add annotation to migrating resources by stork - have stub to cleanup resources for dest cluster Signed-off-by: Ram <[email protected]>
libopenstorage · Nov 27, 2019 · df796e6 · df796e6
1 parent a1da847
commit df796e6
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 10 deletions.
diff --git a/pkg/apis/stork/v1alpha1/migration.go b/pkg/apis/stork/v1alpha1/migration.go
@@ -13,15 +13,16 @@ const (
 
 // MigrationSpec is the spec used to migrate apps between clusterpairs
 type MigrationSpec struct {
-	ClusterPair       string            `json:"clusterPair"`
-	AdminClusterPair  string            `json:"adminClusterPair"`
-	Namespaces        []string          `json:"namespaces"`
-	IncludeResources  *bool             `json:"includeResources"`
-	IncludeVolumes    *bool             `json:"includeVolumes"`
-	StartApplications *bool             `json:"startApplications"`
-	Selectors         map[string]string `json:"selectors"`
-	PreExecRule       string            `json:"preExecRule"`
-	PostExecRule      string            `json:"postExecRule"`
+	ClusterPair            string            `json:"clusterPair"`
+	AdminClusterPair       string            `json:"adminClusterPair"`
+	Namespaces             []string          `json:"namespaces"`
+	IncludeResources       *bool             `json:"includeResources"`
+	IncludeVolumes         *bool             `json:"includeVolumes"`
+	StartApplications      *bool             `json:"startApplications"`
+	AllowCleaningResources *bool             `json:"allowCleaningResources"`
+	Selectors              map[string]string `json:"selectors"`
+	PreExecRule            string            `json:"preExecRule"`
+	PostExecRule           string            `json:"postExecRule"`
 }
 
 // MigrationStatus is the status of a migration operation

diff --git a/pkg/apis/stork/v1alpha1/zz_generated.deepcopy.go b/pkg/apis/stork/v1alpha1/zz_generated.deepcopy.go
diff --git a/pkg/migration/controllers/migration.go b/pkg/migration/controllers/migration.go
@@ -38,6 +38,9 @@ const (
 	// StorkMigrationReplicasAnnotation is the annotation used to keep track of
 	// the number of replicas for an application when it was migrated
 	StorkMigrationReplicasAnnotation = "stork.libopenstorage.org/migrationReplicas"
+	// StorkMigrationAnnotation is the annotation used to keep track of resources
+	// migrated by stork
+	StorkMigrationAnnotation = "stork.libopenstorage.org/storkMigration"
 	// Max number of times to retry applying resources on the desination
 	maxApplyRetries = 10
 )
@@ -284,7 +287,11 @@ func (m *MigrationController) Handle(ctx context.Context, event sdk.Event) error
 			}
 
 		case stork_api.MigrationStageFinal:
-			// Do Nothing
+			// delete resources on destination which are not present on source
+			// TODO: what should be idle location for this
+			if *migration.Spec.AllowCleaningResources {
+				return m.cleanupMigratedResources(migration)
+			}
 			return nil
 		default:
 			log.MigrationLog(migration).Errorf("Invalid stage for migration: %v", migration.Status.Stage)
@@ -293,6 +300,10 @@ func (m *MigrationController) Handle(ctx context.Context, event sdk.Event) error
 	return nil
 }
 
+func (m *MigrationController) cleanupMigratedResources(migration *stork_api.Migration) error {
+	return nil
+}
+
 func (m *MigrationController) namespaceMigrationAllowed(migration *stork_api.Migration) bool {
 	// Restrict migration to only the namespace that the object belongs
 	// except for the namespace designated by the admin
@@ -884,6 +895,10 @@ func (m *MigrationController) applyResources(
 		if !ok {
 			return fmt.Errorf("unable to cast object to unstructured: %v", o)
 		}
+
+		unstructured.SetAnnotations(map[string]string{StorkMigrationAnnotation: "true"})
+		log.MigrationLog(migration).Infof("Applied stork migration annotation %v %v", metadata.GetName(), unstructured.GetAnnotations())
+
 		retries := 0
 		for {
 			_, err = dynamicClient.Create(unstructured)