fix(mdns): mdns interface-state polling

libp2p · Nov 15, 2023 · 727964a · 727964a
1 parent cddc306
commit 727964a
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/protocols/mdns/CHANGELOG.md b/protocols/mdns/CHANGELOG.md
@@ -2,6 +2,8 @@
 
 - Ensure `Multiaddr` handled and returned by `Behaviour` are `/p2p` terminated.
   See [PR 4596](https://github.com/libp2p/rust-libp2p/pull/4596).
+- Fix a bug in the `Behaviour::poll` method causing missed mdns packets.
+  See [PR 4861](https://github.com/libp2p/rust-libp2p/pull/4861).
 
 ## 0.45.0
 

diff --git a/protocols/mdns/src/behaviour/iface.rs b/protocols/mdns/src/behaviour/iface.rs
@@ -312,14 +312,18 @@ where
                 }
                 Poll::Ready(Err(err)) if err.kind() == std::io::ErrorKind::WouldBlock => {
                     // No more bytes available on the socket to read
+                    continue;
                 }
                 Poll::Ready(Err(err)) => {
                     tracing::error!("failed reading datagram: {}", err);
+                    return Poll::Ready(());
                 }
                 Poll::Ready(Ok(Err(err))) => {
                     tracing::debug!("Parsing mdns packet failed: {:?}", err);
+                    continue;
                 }
-                Poll::Ready(Ok(Ok(None))) | Poll::Pending => {}
+                Poll::Ready(Ok(Ok(None))) => continue,
+                Poll::Pending => {}
             }
 
             return Poll::Pending;