Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(connection-limits): correct connection tracking #4250

Merged
merged 15 commits into from
Jul 26, 2023

Merge branch 'master' of https://github.com/libp2p/rust-libp2p into c…

3e43b6c
Select commit
Loading
Failed to load commit list.
Merged

fix(connection-limits): correct connection tracking #4250

Merge branch 'master' of https://github.com/libp2p/rust-libp2p into c…
3e43b6c
Select commit
Loading
Failed to load commit list.
This check has been archived and is scheduled for deletion. Learn more about checks retention
Mergify / Queue: Embarked in merge train succeeded Jul 26, 2023 in 0s

The pull request embarked with master (da743ec) is mergeable

Required conditions for merge:

  • #approved-reviews-by>=1 [🛡 GitHub branch protection]
  • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
  • all of [📃 From pull request rule Add to merge queue]:
    • #approved-reviews-by>=1 [🛡 GitHub branch protection]
    • #changes-requested-reviews-by=0 [🛡 GitHub branch protection]
    • -draft [:pushpin: queue requirement]
    • -mergify-configuration-changed [:pushpin: queue -> allow_merging_configuration_change setting requirement]
    • base=master
    • label=send-it
    • any of [:twisted_rightwards_arrows: queue conditions]:
      • all of [:pushpin: queue conditions of queue default]
    • any of [🛡 GitHub branch protection]:
      • check-success=Check rustdoc intra-doc links
      • check-neutral=Check rustdoc intra-doc links
      • check-skipped=Check rustdoc intra-doc links
    • any of [🛡 GitHub branch protection]:
      • check-success=rustfmt
      • check-neutral=rustfmt
      • check-skipped=rustfmt
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-metrics
      • check-neutral=Test libp2p-metrics
      • check-skipped=Test libp2p-metrics
    • any of [🛡 GitHub branch protection]:
      • check-success=Compile on x86_64-apple-darwin
      • check-neutral=Compile on x86_64-apple-darwin
      • check-skipped=Compile on x86_64-apple-darwin
    • any of [🛡 GitHub branch protection]:
      • check-success=Compile on x86_64-pc-windows-msvc
      • check-neutral=Compile on x86_64-pc-windows-msvc
      • check-skipped=Compile on x86_64-pc-windows-msvc
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-yamux
      • check-neutral=Test libp2p-yamux
      • check-skipped=Test libp2p-yamux
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-swarm
      • check-neutral=Test libp2p-swarm
      • check-skipped=Test libp2p-swarm
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-wasm-ext
      • check-neutral=Test libp2p-wasm-ext
      • check-skipped=Test libp2p-wasm-ext
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-mdns
      • check-neutral=Test libp2p-mdns
      • check-skipped=Test libp2p-mdns
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-relay
      • check-neutral=Test libp2p-relay
      • check-skipped=Test libp2p-relay
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-uds
      • check-neutral=Test libp2p-uds
      • check-skipped=Test libp2p-uds
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-rendezvous
      • check-neutral=Test libp2p-rendezvous
      • check-skipped=Test libp2p-rendezvous
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p
      • check-neutral=Test libp2p
      • check-skipped=Test libp2p
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-noise
      • check-neutral=Test libp2p-noise
      • check-skipped=Test libp2p-noise
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-gossipsub
      • check-neutral=Test libp2p-gossipsub
      • check-skipped=Test libp2p-gossipsub
    • any of [🛡 GitHub branch protection]:
      • check-success=Test rw-stream-sink
      • check-neutral=Test rw-stream-sink
      • check-skipped=Test rw-stream-sink
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-deflate
      • check-neutral=Test libp2p-deflate
      • check-skipped=Test libp2p-deflate
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-dns
      • check-neutral=Test libp2p-dns
      • check-skipped=Test libp2p-dns
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-floodsub
      • check-neutral=Test libp2p-floodsub
      • check-skipped=Test libp2p-floodsub
    • any of [🛡 GitHub branch protection]:
      • check-success=Compile with select features (mdns tcp dns async-std)
      • check-neutral=Compile with select features (mdns tcp dns async-std)
      • check-skipped=Compile with select features (mdns tcp dns async-std)
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-swarm-derive
      • check-neutral=Test libp2p-swarm-derive
      • check-skipped=Test libp2p-swarm-derive
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-pnet
      • check-neutral=Test libp2p-pnet
      • check-skipped=Test libp2p-pnet
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-tls
      • check-neutral=Test libp2p-tls
      • check-skipped=Test libp2p-tls
    • any of [🛡 GitHub branch protection]:
      • check-success=Compile on wasm32-wasi
      • check-neutral=Compile on wasm32-wasi
      • check-skipped=Compile on wasm32-wasi
    • any of [🛡 GitHub branch protection]:
      • check-success=Test multistream-select
      • check-neutral=Test multistream-select
      • check-skipped=Test multistream-select
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-kad
      • check-neutral=Test libp2p-kad
      • check-skipped=Test libp2p-kad
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-core
      • check-neutral=Test libp2p-core
      • check-skipped=Test libp2p-core
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-tcp
      • check-neutral=Test libp2p-tcp
      • check-skipped=Test libp2p-tcp
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-websocket
      • check-neutral=Test libp2p-websocket
      • check-skipped=Test libp2p-websocket
    • any of [🛡 GitHub branch protection]:
      • check-success=IPFS Integration tests
      • check-neutral=IPFS Integration tests
      • check-skipped=IPFS Integration tests
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-identify
      • check-neutral=Test libp2p-identify
      • check-skipped=Test libp2p-identify
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-dcutr
      • check-neutral=Test libp2p-dcutr
      • check-skipped=Test libp2p-dcutr
    • any of [🛡 GitHub branch protection]:
      • check-success=Compile on wasm32-unknown-emscripten
      • check-neutral=Compile on wasm32-unknown-emscripten
      • check-skipped=Compile on wasm32-unknown-emscripten
    • any of [🛡 GitHub branch protection]:
      • check-success=Compile with select features (mdns tcp dns tokio)
      • check-neutral=Compile with select features (mdns tcp dns tokio)
      • check-skipped=Compile with select features (mdns tcp dns tokio)
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-request-response
      • check-neutral=Test libp2p-request-response
      • check-skipped=Test libp2p-request-response
    • any of [🛡 GitHub branch protection]:
      • check-success=Compile on wasm32-unknown-unknown
      • check-neutral=Compile on wasm32-unknown-unknown
      • check-skipped=Compile on wasm32-unknown-unknown
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-mplex
      • check-neutral=Test libp2p-mplex
      • check-skipped=Test libp2p-mplex
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-ping
      • check-neutral=Test libp2p-ping
      • check-skipped=Test libp2p-ping
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-plaintext
      • check-neutral=Test libp2p-plaintext
      • check-skipped=Test libp2p-plaintext
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-autonat
      • check-neutral=Test libp2p-autonat
      • check-skipped=Test libp2p-autonat
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-quic
      • check-neutral=Test libp2p-quic
      • check-skipped=Test libp2p-quic
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-webrtc
      • check-neutral=Test libp2p-webrtc
      • check-skipped=Test libp2p-webrtc
    • any of [🛡 GitHub branch protection]:
      • check-success=Test quick-protobuf-codec
      • check-neutral=Test quick-protobuf-codec
      • check-skipped=Test quick-protobuf-codec
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-identity
      • check-neutral=Test libp2p-identity
      • check-skipped=Test libp2p-identity
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-allow-block-list
      • check-neutral=Test libp2p-allow-block-list
      • check-skipped=Test libp2p-allow-block-list
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-swarm-test
      • check-neutral=Test libp2p-swarm-test
      • check-skipped=Test libp2p-swarm-test
    • any of [🛡 GitHub branch protection]:
      • check-success=Check for changes in proto files
      • check-neutral=Check for changes in proto files
      • check-skipped=Check for changes in proto files
    • any of [🛡 GitHub branch protection]:
      • check-success=Ensure that Cargo.lock is up-to-date
      • check-neutral=Ensure that Cargo.lock is up-to-date
      • check-skipped=Ensure that Cargo.lock is up-to-date
    • any of [🛡 GitHub branch protection]:
      • check-success=Test libp2p-connection-limits
      • check-neutral=Test libp2p-connection-limits
      • check-skipped=Test libp2p-connection-limits
    • any of [🛡 GitHub branch protection]:
      • check-success=examples
      • check-neutral=examples
      • check-skipped=examples
    • any of [🛡 GitHub branch protection]:
      • check-success=Run multidimensional interoperability tests (native)
      • check-neutral=Run multidimensional interoperability tests (native)
      • check-skipped=Run multidimensional interoperability tests (native)
    • any of [🛡 GitHub branch protection]:
      • check-success=Run all WASM tests
      • check-neutral=Run all WASM tests
      • check-skipped=Run all WASM tests
    • any of [🛡 GitHub branch protection]:
      • check-success=Run multidimensional interoperability tests (chromium)
      • check-neutral=Run multidimensional interoperability tests (chromium)
      • check-skipped=Run multidimensional interoperability tests (chromium)
  • any of [🛡 GitHub branch protection]:
    • check-success=Check rustdoc intra-doc links
    • check-neutral=Check rustdoc intra-doc links
    • check-skipped=Check rustdoc intra-doc links
  • any of [🛡 GitHub branch protection]:
    • check-success=rustfmt
    • check-neutral=rustfmt
    • check-skipped=rustfmt
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-metrics
    • check-neutral=Test libp2p-metrics
    • check-skipped=Test libp2p-metrics
  • any of [🛡 GitHub branch protection]:
    • check-success=Compile on x86_64-apple-darwin
    • check-neutral=Compile on x86_64-apple-darwin
    • check-skipped=Compile on x86_64-apple-darwin
  • any of [🛡 GitHub branch protection]:
    • check-success=Compile on x86_64-pc-windows-msvc
    • check-neutral=Compile on x86_64-pc-windows-msvc
    • check-skipped=Compile on x86_64-pc-windows-msvc
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-yamux
    • check-neutral=Test libp2p-yamux
    • check-skipped=Test libp2p-yamux
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-swarm
    • check-neutral=Test libp2p-swarm
    • check-skipped=Test libp2p-swarm
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-wasm-ext
    • check-neutral=Test libp2p-wasm-ext
    • check-skipped=Test libp2p-wasm-ext
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-mdns
    • check-neutral=Test libp2p-mdns
    • check-skipped=Test libp2p-mdns
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-relay
    • check-neutral=Test libp2p-relay
    • check-skipped=Test libp2p-relay
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-uds
    • check-neutral=Test libp2p-uds
    • check-skipped=Test libp2p-uds
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-rendezvous
    • check-neutral=Test libp2p-rendezvous
    • check-skipped=Test libp2p-rendezvous
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p
    • check-neutral=Test libp2p
    • check-skipped=Test libp2p
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-noise
    • check-neutral=Test libp2p-noise
    • check-skipped=Test libp2p-noise
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-gossipsub
    • check-neutral=Test libp2p-gossipsub
    • check-skipped=Test libp2p-gossipsub
  • any of [🛡 GitHub branch protection]:
    • check-success=Test rw-stream-sink
    • check-neutral=Test rw-stream-sink
    • check-skipped=Test rw-stream-sink
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-deflate
    • check-neutral=Test libp2p-deflate
    • check-skipped=Test libp2p-deflate
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-dns
    • check-neutral=Test libp2p-dns
    • check-skipped=Test libp2p-dns
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-floodsub
    • check-neutral=Test libp2p-floodsub
    • check-skipped=Test libp2p-floodsub
  • any of [🛡 GitHub branch protection]:
    • check-success=Compile with select features (mdns tcp dns async-std)
    • check-neutral=Compile with select features (mdns tcp dns async-std)
    • check-skipped=Compile with select features (mdns tcp dns async-std)
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-swarm-derive
    • check-neutral=Test libp2p-swarm-derive
    • check-skipped=Test libp2p-swarm-derive
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-pnet
    • check-neutral=Test libp2p-pnet
    • check-skipped=Test libp2p-pnet
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-tls
    • check-neutral=Test libp2p-tls
    • check-skipped=Test libp2p-tls
  • any of [🛡 GitHub branch protection]:
    • check-success=Compile on wasm32-wasi
    • check-neutral=Compile on wasm32-wasi
    • check-skipped=Compile on wasm32-wasi
  • any of [🛡 GitHub branch protection]:
    • check-success=Test multistream-select
    • check-neutral=Test multistream-select
    • check-skipped=Test multistream-select
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-kad
    • check-neutral=Test libp2p-kad
    • check-skipped=Test libp2p-kad
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-core
    • check-neutral=Test libp2p-core
    • check-skipped=Test libp2p-core
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-tcp
    • check-neutral=Test libp2p-tcp
    • check-skipped=Test libp2p-tcp
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-websocket
    • check-neutral=Test libp2p-websocket
    • check-skipped=Test libp2p-websocket
  • any of [🛡 GitHub branch protection]:
    • check-success=IPFS Integration tests
    • check-neutral=IPFS Integration tests
    • check-skipped=IPFS Integration tests
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-identify
    • check-neutral=Test libp2p-identify
    • check-skipped=Test libp2p-identify
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-dcutr
    • check-neutral=Test libp2p-dcutr
    • check-skipped=Test libp2p-dcutr
  • any of [🛡 GitHub branch protection]:
    • check-success=Compile on wasm32-unknown-emscripten
    • check-neutral=Compile on wasm32-unknown-emscripten
    • check-skipped=Compile on wasm32-unknown-emscripten
  • any of [🛡 GitHub branch protection]:
    • check-success=Compile with select features (mdns tcp dns tokio)
    • check-neutral=Compile with select features (mdns tcp dns tokio)
    • check-skipped=Compile with select features (mdns tcp dns tokio)
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-request-response
    • check-neutral=Test libp2p-request-response
    • check-skipped=Test libp2p-request-response
  • any of [🛡 GitHub branch protection]:
    • check-success=Compile on wasm32-unknown-unknown
    • check-neutral=Compile on wasm32-unknown-unknown
    • check-skipped=Compile on wasm32-unknown-unknown
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-mplex
    • check-neutral=Test libp2p-mplex
    • check-skipped=Test libp2p-mplex
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-ping
    • check-neutral=Test libp2p-ping
    • check-skipped=Test libp2p-ping
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-plaintext
    • check-neutral=Test libp2p-plaintext
    • check-skipped=Test libp2p-plaintext
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-autonat
    • check-neutral=Test libp2p-autonat
    • check-skipped=Test libp2p-autonat
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-quic
    • check-neutral=Test libp2p-quic
    • check-skipped=Test libp2p-quic
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-webrtc
    • check-neutral=Test libp2p-webrtc
    • check-skipped=Test libp2p-webrtc
  • any of [🛡 GitHub branch protection]:
    • check-success=Test quick-protobuf-codec
    • check-neutral=Test quick-protobuf-codec
    • check-skipped=Test quick-protobuf-codec
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-identity
    • check-neutral=Test libp2p-identity
    • check-skipped=Test libp2p-identity
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-allow-block-list
    • check-neutral=Test libp2p-allow-block-list
    • check-skipped=Test libp2p-allow-block-list
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-swarm-test
    • check-neutral=Test libp2p-swarm-test
    • check-skipped=Test libp2p-swarm-test
  • any of [🛡 GitHub branch protection]:
    • check-success=Check for changes in proto files
    • check-neutral=Check for changes in proto files
    • check-skipped=Check for changes in proto files
  • any of [🛡 GitHub branch protection]:
    • check-success=Ensure that Cargo.lock is up-to-date
    • check-neutral=Ensure that Cargo.lock is up-to-date
    • check-skipped=Ensure that Cargo.lock is up-to-date
  • any of [🛡 GitHub branch protection]:
    • check-success=Test libp2p-connection-limits
    • check-neutral=Test libp2p-connection-limits
    • check-skipped=Test libp2p-connection-limits
  • any of [🛡 GitHub branch protection]:
    • check-success=examples
    • check-neutral=examples
    • check-skipped=examples
  • any of [🛡 GitHub branch protection]:
    • check-success=Run multidimensional interoperability tests (native)
    • check-neutral=Run multidimensional interoperability tests (native)
    • check-skipped=Run multidimensional interoperability tests (native)
  • any of [🛡 GitHub branch protection]:
    • check-success=Run all WASM tests
    • check-neutral=Run all WASM tests
    • check-skipped=Run all WASM tests
  • any of [🛡 GitHub branch protection]:
    • check-success=Run multidimensional interoperability tests (chromium)
    • check-neutral=Run multidimensional interoperability tests (chromium)
    • check-skipped=Run multidimensional interoperability tests (chromium)

Check-runs and statuses of the embarked pull request #4250:

clippy (1.71.0)details
clippy (beta)details
Check for changes in proto filesdetails
Check rustdoc intra-doc linksdetails
Compile on wasm32-unknown-emscriptendetails
Compile on wasm32-unknown-unknowndetails
Compile on wasm32-wasidetails
Compile on x86_64-apple-darwindetails
Compile on x86_64-pc-windows-msvcdetails
Compile with MSRVdetails
Compile with select features (mdns tcp dns async-std)details
Compile with select features (mdns tcp dns tokio)details
Ensure that `Cargo.lock` is up-to-datedetails
IPFS Integration testsdetails
Run all WASM testsdetails
Run multidimensional interoperability tests (chromium)details
Run multidimensional interoperability tests (native)details
Test libp2pdetails
Test libp2p-allow-block-listdetails
Test libp2p-autonatdetails
Test libp2p-connection-limitsdetails
Test libp2p-coredetails
Test libp2p-dcutrdetails
Test libp2p-deflatedetails
Test libp2p-dnsdetails
Test libp2p-floodsubdetails
Test libp2p-gossipsubdetails
Test libp2p-identifydetails
Test libp2p-identitydetails
Test libp2p-kaddetails
Test libp2p-mdnsdetails
Test libp2p-metricsdetails
Test libp2p-mplexdetails
Test libp2p-noisedetails
Test libp2p-perfdetails
Test libp2p-pingdetails
Test libp2p-plaintextdetails
Test libp2p-pnetdetails
Test libp2p-quicdetails
Test libp2p-relaydetails
Test libp2p-rendezvousdetails
Test libp2p-request-responsedetails
Test libp2p-swarmdetails
Test libp2p-swarm-derivedetails
Test libp2p-swarm-testdetails
Test libp2p-tcpdetails
Test libp2p-tlsdetails
Test libp2p-udsdetails
Test libp2p-wasm-extdetails
Test libp2p-webrtcdetails
Test libp2p-websocketdetails
Test libp2p-webtransport-websysdetails
Test libp2p-yamuxdetails
Test multistream-selectdetails
Test quick-protobuf-codecdetails
Test rw-stream-sinkdetails
cargo-deny (advisories)details
cargo-deny (bans licenses sources)details
examplesdetails
gather_published_cratesdetails
main / Validate PR titledetails
manifest_lintdetails
rustfmtdetails