Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(webrtc example): clarify idle connection timeout #4966

Merged
merged 10 commits into from
Dec 5, 2023
Merged

fix(webrtc example): clarify idle connection timeout #4966

merged 10 commits into from
Dec 5, 2023

Commits on Nov 30, 2023

  1. set timeout to slightly greater than Ping interval 

    The example was timing out because the idle connection time was 5 seconds and the ping interval is 15s
    @DougAnderson444
    DougAnderson444 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    c0576d2 View commit details
    Browse the repository at this point in the history

  2. add install note for wasm-pack to README 

    it's the small things that help out new users
    @DougAnderson444
    DougAnderson444 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    2c94a3f View commit details
    Browse the repository at this point in the history

  3. set idle timeout to u64::MAX 

    Since Ping does not `KeepAlive`, we set the idle timeout to a very large number of seconds
    @DougAnderson444
    DougAnderson444 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    6c8ffb9 View commit details
    Browse the repository at this point in the history

  4. extend the idle timeout on the server

    @DougAnderson444
    DougAnderson444 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    ea9d6fd View commit details
    Browse the repository at this point in the history

  5. set wasm32 target idle value to maximum 

    For some reason, the largest value that works in wasm32 target (in Chrome) is 32_212_254u64.

Everything larger than this breaks in the browser. Cause unknown at this point.
    @DougAnderson444
    DougAnderson444 committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    2111a07 View commit details
    Browse the repository at this point in the history

  6. Merge branch 'libp2p:master' into fix-webrtc-example

    @DougAnderson444
    DougAnderson444 authored Nov 30, 2023
    Configuration menu
    Copy the full SHA
    1ea52f1 View commit details
    Browse the repository at this point in the history

Commits on Dec 1, 2023

  1. add verbose 30s beginning, duration, and end 

    Added more clarity about how long the Ping is intended to last, and made it a bit more obvious that the ConnectionClosed event is expected in the case of `Ping` after the idle timeout expires
    @DougAnderson444
    DougAnderson444 committed Dec 1, 2023
    Configuration menu
    Copy the full SHA
    e27bd7a View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2023

  1. rm the else after break; 

    as per @thomaseizinger 's comment
    @DougAnderson444
    DougAnderson444 committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    89747b9 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-webrtc-example

    @DougAnderson444
    DougAnderson444 authored Dec 5, 2023
    Configuration menu
    Copy the full SHA
    3e1a8f6 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into fix-webrtc-example

    @mergify
    mergify[bot] authored Dec 5, 2023
    Configuration menu
    Copy the full SHA
    34b6476 View commit details
    Browse the repository at this point in the history