fix(swarm): don't report NewExternalAddrCandidate if already confirmed
#5582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxs
approved these changes
Aug 30, 2024
dariusc93
approved these changes
Aug 30, 2024
…xternal-addresses
|
This PR is not marked |
…xternal-addresses
|
rust-libp2p/misc/quick-protobuf-codec/src/lib.rs Lines 14 to 16 in a2a2816 |
|
@dariusc93 May you get the checks running again and merge this? |
…xternal-addresses
…xternal-addresses
|
|
sdbondi
added a commit
to sdbondi/rust-libp2p
that referenced
this pull request
Nov 1, 2024
* master: (36 commits) chore: refactor ping tests (libp2p#5655) feat: refactor distributed-key-value-store example (libp2p#5652) chore(ci): address clippy beta lints (libp2p#5649) feat(gossipsub): apply `max_transmit_size` to the published message (libp2p#5642) feat(kad): add `Behavior::find_closest_local_peers()` (libp2p#5645) fix(swarm-test): set proper version (libp2p#5648) deps(ci): update cargo-semver-checks (libp2p#5647) chore: fix typo in comment (libp2p#5643) feat: make runtime features optional in swarm-test (libp2p#5551) deps: bump Swatinem/rust-cache from 2.7.3 to 2.7.5 (libp2p#5633) chore: update igd-next to 0.15.1 (libp2p#5625) fix(server): removing dependency on libp2p-lookup (libp2p#5610) refactor(examples): use tokio instead of async-std in relay-server (libp2p#5600) deps: update metrics example dependencies (libp2p#5617) chore: update interop test run condition (libp2p#5611) chore(autonat-v2): fix dial_back_to_non_libp2p test (libp2p#5621) fix(swarm): don't report `NewExternalAddrCandidate` if already confirmed (libp2p#5582) chore(ci): address beta clippy lints (libp2p#5606) fix(ci): address cargo-deny advisories (libp2p#5596) chore(ci): only run interop tests on commits to master (libp2p#5604) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently,
NewExternalAddrCandidateevents are emitted for every connections. However, we continue to get this event even whenautonathas already confirmed that this address is external. So we should not continue to advertise the "candidate" event.Notes & open questions
We have made the changes in the
swarminstead ofidentifybecause it does not make it necessary to duplicate theConfirmedExternalAddrvector in theidentifyBehaviour. Moreover, if any future Behaviour emitNewExternalAddrCandidate, the same rule will also be applied.I had to edit the
autonat_v2tests which were always expecting aNewExternalAddrCandidatebut the address was already confirmed.Change checklist