Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(gossispsub): deprecate futures-ticker #5674

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

chore(gossispsub): deprecate futures-ticker #5674

wants to merge 2 commits into from
+31 −42

Conversation

jxs
Copy link
Member

@jxs jxs commented Nov 12, 2024

Description

to address RUSTSEC-2024-0384 . Use futures-timer and Delay instead

@jxs jxs marked this pull request as draft November 12, 2024 13:32
@jxs
Copy link
Member Author

jxs commented Nov 12, 2024

will also update if-watch and cut a new release to then update this Cargo.lock

@jxs jxs changed the title chore(gossispsub): deprecate future-ticker chore(gossispsub): deprecate futures-ticker Nov 12, 2024
@jxs jxs marked this pull request as ready for review November 12, 2024 16:57
dariusc93
dariusc93 reviewed Nov 13, 2024
View reviewed changes
Copy link
Member

@dariusc93 dariusc93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might want to bump the version in Cargo.toml and update the CHANGELOG.md :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dariusc93 dariusc93 dariusc93 left review comments

@guillaumemichel guillaumemichel Awaiting requested review from guillaumemichel

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jxs @dariusc93