fix: add mystery comment

[achingbrain]

Not quite sure why this is necessary but it means the correct file ends up in the docker container when building from scratch.

---

Investigation from the Slack thread:

Ok, I’ve been digging into this and what I’ve found is that when there’s a cache miss, we build from scratch.

The v1.x and v2.x Makefiles both run docker build in the correct implementation directory:

• https://github.com/libp2p/test-plans/blob/master/transport-interop/impl/js/v1.x/Makefile#L28
• https://github.com/libp2p/test-plans/blob/master/transport-interop/impl/js/v2.x/Makefile#L28

I have a branch in the test-plans repo called fix/debug-js-build. In the branch it does the following:

1. cat the test/fixtures/relay.js file before running docker build -

   test-plans/transport-interop/impl/js/v2.x/Makefile

   Line 28 in a7ff620

   cat $(PWD)/test/fixtures/relay.ts

2. cat it during the build after it’s been added to the container -

   test-plans/transport-interop/impl/js/v2.x/Dockerfile

   Line 14 in a7ff620

   RUN cat test/fixtures/relay.ts

If I use this branch to run the ping interop test, the test/fixtures/relay.js file in the container does not have the same content as the one in the context directory (see connectionEncrypters vs connectionEncryption):

• before running docker build - https://github.com/libp2p/js-libp2p/actions/runs/12235431303/job/34137698038#step:6:886
• after adding the file to the container - https://github.com/libp2p/js-libp2p/actions/runs/12235431303/job/34137698038#step:6:954

Very strange.

The only way I’ve been able to get the test/fixtures/relay.js file to have the correct content is to change it’s name so the v2.x file doesn’t have the same path as the v1.x file. I only get the renamed file in the docker image, not the one with the original name.

Also, if I remove the v1.x folder so only build the v2.x version, the file has the correct contents, so some cache must be getting reused between the v1.x and v2.x builds, though both build from the node:lts image without using any other base images.

I’m at a bit of a loss about how this is possible, perhaps someone with a bit more docker knowledge has some ideas?

[achingbrain]

@p-shahi @MarcoPolo @galargh this is such a hack - do you have any idea why the wrong file ends up in the container without this?

The error it fixes is this sort of thing: https://github.com/libp2p/test-plans/actions/runs/12243585872/job/34153471788?pr=586#step:3:46235

[MarcoPolo]

Thanks for debugging this. I'll try to tal today.

[p-shahi]

Trying a few things on a branch here: #589

[p-shahi]

I think the cache busting fixes this issue: https://github.com/libp2p/test-plans/actions/runs/12266838240/job/34225761983?pr=589 without needing to add the mystery comment
I don't know the root cause of this issue though

[MarcoPolo]

Which cache are you busting? The testplans one or the docker one?

[MarcoPolo]

Does this reproduce locally or only in CI?

[p-shahi]

I'm busting the cache only for the v2.x image builds. In case the problem is happening because of cached layers between the v1.x and v2.x images
I didn't try reproducing locally

[achingbrain]

Which cache are you busting? The testplans one or the docker one?

Docker - the problem only occurs when there's an S3 cache miss and this branch is hit. I guess #589 works because setting the env var before copying the files means the cache for the subsequent steps is invalidated.

FWIW I also tried the --no-cache option to docker build though it doesn't seem to help.

Pruning the layer cache before building also seems to fix the problem and is probably a better approach than this PR though I'm still not sure why it's necessary. It doesn't seem to affect build time much which is something at least.

Does this reproduce locally or only in CI?

I didn't try reproducing locally

Like all the best issues, I could only reproduce this in CI, locally everything works as expected 😭

[p-shahi]

@MarcoPolo @achingbrain since this is still causing issues in rust-libp2p and probably elsewhere, what should we do here. Merge #590 and create an issue with a reminder to investigate further?

@galargh do you have any thoughts?

[galargh]

Sorry I missed this earlier, I'll try to have a look later today.

[p-shahi]

@galargh any progress?