feat: Support for feed pagination #3739
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bnyro
force-pushed
the
feed-pagination
branch
4 times, most recently
from
9ad6193
to
468e385
Compare
I should really create a new 'alpha' or something similar instance for testing changes 🤔 |
|
That would be ideal, yes. |
|
The AndroidX Paging library might be useful: https://developer.android.com/jetpack/androidx/releases/paging |
|
True, that could likely be used at other places too such as the search adapter or the playlist videos adapter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #3693
This will probably also cause the feed sorting feature by views and uploader name to not work anymore.
The changes have not been tested yet as there's no instance already supporting feed pagination. However, they should be tested before creating a new release.