Ensure that wan interface gets configured on DSA devices, where wan could be the name of the interface #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the same should be done for interfaces named lan, lan1, lan2 etc. |
I agree. @G10h4ck please merge this unless you have a general idea on how to solve the issue. |
G10h4ck
approved these changes
Sep 24, 2024
|
Cherry-picked to 2024.1 branch for the next release https://github.com/libremesh/lime-packages/commits/2024.1/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially proposed in this comment: #1080 (comment)
On DSA devices, the "wan" interface could be named just "wan", without having any lower interface.
This ensures that it gets configured by the protocols even if it has no lower interface.
@pony1k @G10h4ck do you think that the same will be needed for LAN?