Attempt to fix 2038 problem with MSVC #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You may want to wrap winsock select() as well to ensure that it will still see the timeval struct layout it expects. |
|
Tested on OpenSSH portable, and it fixes the issues on Win32 builds. |
|
On Tue, Aug 06, 2024 at 02:18:34AM -0700, LainOTN2 wrote:
Tested on OpenSSH portable, and it fixes the issues on Win32 builds.
Many thanks for testing!
I'll see how to deal with select (thanks @datadiode!) and will get this
into mergeable shape for the next release.
|
Otherwise it sets looptime to -1, which was skipped by select() and caused 100% cpu busy looping.
This prevents the compatibility struct timeval definition in sys/time.h from potentially getting used with select() here. https://learn.microsoft.com/en-us/windows/win32/api/winsock2/nf-winsock2-select
|
I made a change to poll_win.c to ensure that we use the appropriate timeval definition with select with Windows. We were anyway, because sys/time.h isn't used in Windows' select definition, but still just in case. This also fixes an issue where select was given {0, 4294967296} when poll was given a timeout value of -1, which caused poll() to spin with no timeout internally, noticed while logging internal behavior with |
|
Going to land this now |
|
On Mon, Oct 07, 2024 at 08:22:28PM -0700, Brent Cook wrote:
Going to land this now
Thanks. Sorry, didn't get around to reviewing it yesterday. Looks good
to me.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might fix #1076