Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Append version to dll on CMake #1084

Merged
merged 3 commits into from
Oct 1, 2024
Merged

Append version to dll on CMake #1084

merged 3 commits into from
Oct 1, 2024
+11 −17

Conversation

ikspress
Copy link
Contributor

Fixes #1083

@botovq botovq requested a review from busterb August 21, 2024 14:15
botovq
botovq approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@botovq botovq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this makes sense to me. I'm fine with doing this, but I would like to give @busterb some time to comment.

@busterb busterb self-assigned this Oct 1, 2024
@busterb
Copy link
Contributor

busterb commented Oct 1, 2024

This seems like the right way to do this. Thanks @ikspress

This does bump our minimum CMake version to 3.27, which I'm fine with https://cmake.org/cmake/help/latest/prop_tgt/DLL_NAME_WITH_SOVERSION.html

To get the unversioned behavior, a user can set CMAKE_PLATFORM_NO_VERSIONED_SONAME

busterb
busterb approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@busterb busterb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build failures in the CI re-run are just from this needing a rebase for changes in master openbsd branch since it was submitted.

@busterb busterb merged commit c04ca24 into libressl:master Oct 1, 2024
30 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@busterb busterb busterb approved these changes

@botovq botovq botovq approved these changes

Assignees

@busterb busterb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inconsistent DLL name built by CMake and autotools
3 participants
@ikspress @busterb @botovq