Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: improve cmake config workflow #1135

Merged
merged 2 commits into from
Jan 11, 2025

Conversation

joshuasing
Copy link
Member

@joshuasing joshuasing commented Jan 11, 2025

Tidy up the CMake config check workflow:

  1. Follow same style as other workflows
  2. Set strategy.fail-fast: true, so that all workflow runs for a ref are cancelled if one OS fails (is this correct?)
  3. Restrict token permissions to contents: read.
  4. Pin runner images to versions, instead of using windows-latest and macos-latest.
  5. Rename file cmake_config.yml -> cmake-config.yml to match other workflows.

@joshuasing joshuasing requested a review from botovq January 11, 2025 11:39
Copy link
Contributor

@botovq botovq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the future, it would be nice if you could make the rename a separate commit. This would make sure the actual changes are visible in diff format rather than having to resort to doing this by hand.

Likewise, I wouldn't mind having cosmetics like adding quotes and pure whitespace changes in separate commits. This makes it much easier to focus on the actual changes.

@joshuasing
Copy link
Member Author

For the future, it would be nice if you could make the rename a separate commit. This would make sure the actual changes are visible in diff format rather than having to resort to doing this by hand.

Likewise, I wouldn't mind having cosmetics like adding quotes and pure whitespace changes in separate commits. This makes it much easier to focus on the actual changes.

Sure, will do. Sorry for the inconvenience.
Are separate commits in one pull request okay, or would separate pull requests (with one commit per pull request) be better?

@botovq
Copy link
Contributor

botovq commented Jan 11, 2025

A single PR is ok, containing a stack of commits where each commit does a single change each (one commit adding all the quotes, one commit making whitespace cosmetics and one commit containing the actual change).

@botovq botovq merged commit 2c8bc60 into libressl:master Jan 11, 2025
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants