Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small warning fixes #15877

Merged
merged 1 commit into from
Nov 6, 2023
Merged

Conversation

zoltanvb
Copy link
Contributor

@zoltanvb zoltanvb commented Nov 6, 2023

Description

This should remove the final 2 warnings that are currently in Linux x64 compilation:

input/drivers/udev_input.c: In function 'udev_input_add_device':
input/drivers/udev_input.c:3229:12: warning: variable 'touch' set but not used [-Wunused-but-set-variable]
 3229 |       bool touch = 0;
      |            ^~~~~

and

In file included from /usr/include/x86_64-linux-gnu/qt5/QtGui/qbrush.h:39,
                 from /usr/include/x86_64-linux-gnu/qt5/QtGui/qpalette.h:39,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qwidget.h:41,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qdialog.h:37,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/qprogressdialog.h:37,
                 from /usr/include/x86_64-linux-gnu/qt5/QtWidgets/QProgressDialog:1,
                 from ui/drivers/qt/qt_downloads.cpp:3:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h: In instantiation of 'QVector<T>::iterator QVector<T>::erase(QVector<T>::iterator, QVector<T>::iterator) [with T = QHash<QString, QString>; QVector<T>::iterator = QHash<QString, QString>*]':
/usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:418:3:   required from 'void QVector<T>::remove(int) [with T = QHash<QString, QString>]'
/usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:173:36:   required from 'T QVector<T>::takeAt(int) [with T = QHash<QString, QString>]'
ui/drivers/qt/qt_downloads.cpp:768:83:   required from here
/usr/include/x86_64-linux-gnu/qt5/QtCore/qvector.h:711:20: warning: 'void* memmove(void*, const void*, size_t)' writing to an object of type 'class QHash<QString, QString>' with no trivial copy-assignment; use copy-assignment or copy-initialization instead [-Wclass-memaccess]
  711 |             memmove(abegin, aend, (d->size - itemsToErase - itemsUntouched) * sizeof(T));
      |             ~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /usr/include/x86_64-linux-gnu/qt5/QtCore/qshareddata.h:39,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/qfileinfo.h:39,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/qdir.h:38,
                 from /usr/include/x86_64-linux-gnu/qt5/QtCore/QDir:1,
                 from ui/drivers/qt/qt_downloads.cpp:1:
/usr/include/x86_64-linux-gnu/qt5/QtCore/qhash.h:315:7: note: 'class QHash<QString, QString>' declared here
  315 | class QHash
      |       ^~~~~

It is not terribly important, but removing these helps spotting any new issue.

@LibretroAdmin LibretroAdmin merged commit c42498e into libretro:master Nov 6, 2023
22 checks passed
@zoltanvb zoltanvb deleted the udev_qt_warningfix branch November 11, 2023 09:44
Sunderland93 pushed a commit to Sunderland93/RetroArch that referenced this pull request Dec 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants