(WIN32) Prefer D3D11 and WASAPI #15913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sunderland93
pushed a commit
to Sunderland93/RetroArch
that referenced
this pull request
Dec 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since D3D11 and WASAPI have been very usable and robust for a long time, let's prefer them as the default drivers where available. I don't see any practical reason to keep defaulting to the old OPENGL2 when D3D11 or even when OPENGL3 exists.
Or perhaps both of these D3D11 defines for Xbox and Win32 before OPENGL could be combined as one single
HAVE_D3D11, or rather just remove both and move the actual one below to the top?This should also allow getting rid of the dx9 redist required for the older xaudio.
Also enabled WASAPI in
Makefile.msvcsince it seems very wrong to not have it there, or am I wrong?